From: Jouni Malinen <jouni@codeaurora.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Kyeyoon Park <kyeyoonp@codeaurora.org>,
Jouni Malinen <jouni@codeaurora.org>
Subject: [PATCH 1/3] bridge: Base the BR_PROXYARP decision on the target port flag
Date: Wed, 4 Feb 2015 11:51:05 +0200 [thread overview]
Message-ID: <1423043467-11148-1-git-send-email-jouni@codeaurora.org> (raw)
From: Kyeyoon Park <kyeyoonp@codeaurora.org>
When doing proxy ARP, instead of checking the bridge port flag for
BR_PROXYARP on the bridge port on which the frame was received, check
the bridge port flag of the bridge port to which the target device
belongs.
Signed-off-by: Kyeyoon Park <kyeyoonp@codeaurora.org>
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
---
net/bridge/br_input.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index e2aa7be..cfd46c6 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -105,7 +105,7 @@ static void br_do_proxy_arp(struct sk_buff *skb, struct net_bridge *br,
}
f = __br_fdb_get(br, n->ha, vid);
- if (f)
+ if (f && f->dst->flags & BR_PROXYARP)
arp_send(ARPOP_REPLY, ETH_P_ARP, sip, skb->dev, tip,
sha, n->ha, sha);
@@ -155,7 +155,6 @@ int br_handle_frame_finish(struct sk_buff *skb)
if (is_broadcast_ether_addr(dest)) {
if (IS_ENABLED(CONFIG_INET) &&
- p->flags & BR_PROXYARP &&
skb->protocol == htons(ETH_P_ARP))
br_do_proxy_arp(skb, br, vid);
--
1.9.1
next reply other threads:[~2015-02-04 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 9:51 Jouni Malinen [this message]
2015-02-04 9:51 ` [PATCH 2/3] bridge: Selectively prevent bridge port flooding for proxy ARP Jouni Malinen
2015-02-04 9:51 ` [PATCH 3/3] bridge: Allow proxy ARP for unicast ARP requests Jouni Malinen
2015-02-04 23:13 ` [PATCH 1/3] bridge: Base the BR_PROXYARP decision on the target port flag Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423043467-11148-1-git-send-email-jouni@codeaurora.org \
--to=jouni@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kyeyoonp@codeaurora.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).