Netdev List
 help / color / mirror / Atom feed
From: Jon Maloy <jon.maloy@ericsson.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	erik.hugne@ericsson.com, ying.xue@windriver.com,
	maloy@donjonn.com, tipc-discussion@lists.sourceforge.net,
	Jon Maloy <jon.maloy@ericsson.com>
Subject: [PATCH net-next 0/9] tipc: resolve message disordering problem
Date: Thu,  5 Feb 2015 08:36:35 -0500	[thread overview]
Message-ID: <1423143404-23322-1-git-send-email-jon.maloy@ericsson.com> (raw)

When TIPC receives messages from multi-threaded device drivers it may
occasionally deliver messages to their destination sockets in the wrong
order. This happens despite correct resequencing at the link layer,
because the upcall path from link to socket is not protected by any
locks.

These commits solve this problem by introducing an 'input' message
queue in each link, through which messages must be delivered to the
upper layers.


Jon Maloy (9):
  tipc: reduce usage of context info in socket and link
  tipc: simplify message forwarding and rejection in socket layer
  tipc: enqueue arrived buffers in socket in separate function
  tipc: split up function tipc_msg_eval()
  tipc: use existing sk_write_queue for outgoing packet chain
  tipc: resolve race problem at unicast message reception
  tipc: simplify connection abort notifications when links break
  tipc: simplify socket multicast reception
  tipc: eliminate race condition at multicast reception

 net/tipc/bcast.c      | 121 ++++++----------
 net/tipc/bcast.h      |  29 ++--
 net/tipc/discover.c   |   3 +-
 net/tipc/link.c       | 301 +++++++++++++++++----------------------
 net/tipc/link.h       |  14 +-
 net/tipc/msg.c        | 109 ++++++++------
 net/tipc/msg.h        | 107 ++++++++++++--
 net/tipc/name_distr.c |  38 +++--
 net/tipc/name_distr.h |   2 +-
 net/tipc/name_table.c |  44 +++++-
 net/tipc/name_table.h |  20 ++-
 net/tipc/node.c       | 103 +++++++-------
 net/tipc/node.h       |  22 ++-
 net/tipc/socket.c     | 382 +++++++++++++++++++++++++++++---------------------
 net/tipc/socket.h     |   8 +-
 15 files changed, 740 insertions(+), 563 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-02-05 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 13:36 Jon Maloy [this message]
2015-02-05 13:36 ` [PATCH net-next 1/9] tipc: reduce usage of context info in socket and link Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 2/9] tipc: simplify message forwarding and rejection in socket layer Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 3/9] tipc: enqueue arrived buffers in socket in separate function Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 4/9] tipc: split up function tipc_msg_eval() Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 5/9] tipc: use existing sk_write_queue for outgoing packet chain Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 6/9] tipc: resolve race problem at unicast message reception Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 7/9] tipc: simplify connection abort notifications when links break Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 8/9] tipc: simplify socket multicast reception Jon Maloy
2015-02-05 13:36 ` [PATCH net-next 9/9] tipc: eliminate race condition at " Jon Maloy
2015-02-06  0:00 ` [PATCH net-next 0/9] tipc: resolve message disordering problem David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423143404-23322-1-git-send-email-jon.maloy@ericsson.com \
    --to=jon.maloy@ericsson.com \
    --cc=davem@davemloft.net \
    --cc=erik.hugne@ericsson.com \
    --cc=maloy@donjonn.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox