Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

Sergei Shtylyov
2016-12-16T19:08:22Z

Hello.

On 12/16/2016 09:21 PM, Ozgur Karatas wrote:

> This patch fixed to keyboard typo, brackets not closed.
> I think, it should be close to parenthes.
>
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
> ---
> tools/net/bpf_dbg.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletions(-)
>
> diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
> index 4f254bc..f715f46 100644
> --- a/tools/net/bpf_dbg.c
> +++ b/tools/net/bpf_dbg.c
> @@ -1213,7 +1213,7 @@ static int cmd_disassemble(char *line_string)
>
> if (!bpf_prog_loaded())
> return CMD_ERR;
> - if (strlen(line_string) > 0 &&
> + if (strlen(line_string) > 0 &&)

Have tried to you compile that? :-/

> (line = strtoul(line_string, NULL, 10)) < bpf_prog_len)

I think the code was correct before your patch...

> single_line = true;
> if (single_line)

MBR, Sergei