From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 14/16] i40evf: disable NAPI polling sooner
Date: Mon, 23 Feb 2015 18:11:19 -0800 [thread overview]
Message-ID: <1424743881-30485-15-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1424743881-30485-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
When closing the interface, disable NAPI polling before any other
activities. This fixes an occasional panic during close caused by the
driver trying to delete and clean rings at the same time.
Change-ID: Ib4d427b13d310258ea85b248d535da70ecf0c1e9
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index b1ca9dd..eb1ac22 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -959,6 +959,7 @@ void i40evf_down(struct i40evf_adapter *adapter)
usleep_range(500, 1000);
i40evf_irq_disable(adapter);
+ i40evf_napi_disable_all(adapter);
/* remove all MAC filters */
list_for_each_entry(f, &adapter->mac_filter_list, list) {
@@ -985,8 +986,6 @@ void i40evf_down(struct i40evf_adapter *adapter)
netif_tx_stop_all_queues(netdev);
- i40evf_napi_disable_all(adapter);
-
msleep(20);
netif_carrier_off(netdev);
--
1.9.3
next prev parent reply other threads:[~2015-02-24 2:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 2:11 [net-next v2 00/16][pull request] Intel Wired LAN Driver Updates 2015-02-23 Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 01/16] e1000e: initial support for i219 Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 02/16] igbvf: Fix code comments and whitespace Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 03/16] igbvf: cleanup msleep() and min/max() usage Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 04/16] i40e: update Shadow RAM read/write functions Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 05/16] i40e: rename debugfs clear_stats option Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 06/16] i40e/i40evf: Refactor the receive routines Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 07/16] i40e/i40evf: restrict VC opcodes to their initial values Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 08/16] i40e: Use #define for the VSI connection type Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 09/16] i40e/i40evf: i40e_register.h updates Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 10/16] i40e: Fix the EMPR interrupt received handling Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 11/16] i40e/i40evf: Remove unused variable an_enable and function update_link_info Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 12/16] i40e/i40evf: Bump Driver Versions Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 13/16] i40e: Fix i40e_ndo_set_vf_spoofchk Jeff Kirsher
2015-02-24 2:11 ` Jeff Kirsher [this message]
2015-02-24 2:11 ` [net-next v2 15/16] i40evf: refactor reset Jeff Kirsher
2015-02-24 2:11 ` [net-next v2 16/16] i40evf: don't wait forever Jeff Kirsher
2015-02-24 2:58 ` [net-next v2 00/16][pull request] Intel Wired LAN Driver Updates 2015-02-23 David Miller
2015-02-24 6:50 ` Jeff Kirsher
2015-02-24 16:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424743881-30485-15-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox