From: Robert Dolca <robert.dolca@intel.com>
To: linux-nfc@lists.01.org,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Robert Dolca <robert.dolca@intel.com>
Subject: [PATCH 7/8] NFC: NCI: Adds a way to get the new connection ID
Date: Tue, 24 Feb 2015 12:01:51 +0200 [thread overview]
Message-ID: <1424772112-27399-8-git-send-email-robert.dolca@intel.com> (raw)
In-Reply-To: <1424772112-27399-1-git-send-email-robert.dolca@intel.com>
nci_core_conn_create not has a new parameter so it can return
the ID of the new connection. Also not you can't call nci_core_conn_create
without waiting the answer for the previous call.
Signed-off-by: Robert Dolca <robert.dolca@intel.com>
---
drivers/nfc/st21nfcb/st21nfcb_se.c | 2 +-
include/net/nfc/nci_core.h | 11 ++++++++---
net/nfc/nci/core.c | 13 ++++++++++---
net/nfc/nci/rsp.c | 6 ++++++
4 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/st21nfcb/st21nfcb_se.c b/drivers/nfc/st21nfcb/st21nfcb_se.c
index 7c82e9d..8694675 100644
--- a/drivers/nfc/st21nfcb/st21nfcb_se.c
+++ b/drivers/nfc/st21nfcb/st21nfcb_se.c
@@ -515,7 +515,7 @@ static int st21nfcb_hci_network_init(struct nci_dev *ndev)
r = nci_core_conn_create(ndev, NCI_DESTINATION_NFCEE, 1,
sizeof(struct core_conn_create_dest_spec_params) +
sizeof(struct dest_spec_params),
- dest_params);
+ dest_params, NULL);
if (r != NCI_STATUS_OK)
goto free_dest_params;
diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h
index d79f90e..a331755 100644
--- a/include/net/nfc/nci_core.h
+++ b/include/net/nfc/nci_core.h
@@ -240,6 +240,11 @@ struct nci_dev {
/* Save RF Discovery ID or NFCEE ID under conn_create */
__u8 cur_id;
+ /* Pointer to the address where the next connection ID
+ * will be stored */
+ __u8 *next_conn_id;
+ __u8 conn_busy;
+
/* stored during nci_data_exchange */
struct sk_buff *rx_data_reassembly;
@@ -266,9 +271,9 @@ int nci_set_config(struct nci_dev *ndev, __u8 id, size_t len, __u8 *val);
int nci_nfcee_discover(struct nci_dev *ndev, u8 action);
int nci_nfcee_mode_set(struct nci_dev *ndev, u8 nfcee_id, u8 nfcee_mode);
int nci_core_conn_create(struct nci_dev *ndev, u8 destination_type,
- u8 number_destination_params,
- size_t params_len,
- struct core_conn_create_dest_spec_params *params);
+ u8 number_destination_params, size_t params_len,
+ struct core_conn_create_dest_spec_params *params,
+ u8 *conn_id);
int nci_core_conn_close(struct nci_dev *ndev, u8 conn_id);
struct nci_hci_dev *nci_hci_allocate(struct nci_dev *ndev);
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index d2e7adf..aaa56f1 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -554,14 +554,19 @@ static void nci_core_conn_create_req(struct nci_dev *ndev, unsigned long opt)
}
int nci_core_conn_create(struct nci_dev *ndev, u8 destination_type,
- u8 number_destination_params,
- size_t params_len,
- struct core_conn_create_dest_spec_params *params)
+ u8 number_destination_params, size_t params_len,
+ struct core_conn_create_dest_spec_params *params,
+ u8 *conn_id)
{
int r;
struct nci_core_conn_create_cmd *cmd;
struct core_conn_create_data data;
+ if (ndev->conn_busy)
+ return -EBUSY;
+
+ ndev->conn_busy = 1;
+
data.length = params_len + sizeof(struct nci_core_conn_create_cmd);
cmd = kzalloc(data.length, GFP_KERNEL);
if (!cmd)
@@ -573,11 +578,13 @@ int nci_core_conn_create(struct nci_dev *ndev, u8 destination_type,
data.cmd = cmd;
ndev->cur_id = params->value[DEST_SPEC_PARAMS_ID_INDEX];
+ ndev->next_conn_id = conn_id;
r = __nci_request(ndev, nci_core_conn_create_req,
(unsigned long)&data,
msecs_to_jiffies(NCI_CMD_TIMEOUT));
kfree(cmd);
+ ndev->conn_busy = 0;
return r;
}
EXPORT_SYMBOL(nci_core_conn_create);
diff --git a/net/nfc/nci/rsp.c b/net/nfc/nci/rsp.c
index 02486bc..9aa9de2 100644
--- a/net/nfc/nci/rsp.c
+++ b/net/nfc/nci/rsp.c
@@ -244,6 +244,12 @@ static void nci_core_conn_create_rsp_packet(struct nci_dev *ndev,
conn_info->id = ndev->cur_id;
conn_info->conn_id = rsp->conn_id;
+ /* Set the conn ID to the address provided by the caller */
+ if (ndev->next_conn_id) {
+ *ndev->next_conn_id = rsp->conn_id;
+ ndev->next_conn_id = NULL;
+ }
+
/* Note: data_exchange_cb and data_exchange_cb_context need to
* be specify out of nci_core_conn_create_rsp_packet
*/
--
1.9.1
next prev parent reply other threads:[~2015-02-24 10:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 10:01 [PATCH 0/8] Adds Intel FieldsPeak NFC solution driver Robert Dolca
2015-02-24 10:01 ` [PATCH 1/8] NFC: NCI: Allow connection close with dev down Robert Dolca
2015-03-26 0:29 ` Samuel Ortiz
2015-03-31 14:03 ` [linux-nfc] " Robert Dolca
2015-05-24 17:07 ` Samuel Ortiz
2015-08-28 14:05 ` Robert Dolca
2015-02-24 10:01 ` [PATCH 2/8] NFC: NCI: Exporting NFC command and data send API Robert Dolca
2015-02-24 10:01 ` [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers Robert Dolca
[not found] ` <1424772112-27399-4-git-send-email-robert.dolca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-26 0:29 ` Samuel Ortiz
[not found] ` <20150326002937.GB10954-41CF7WKNp/H9zxVx7UNMDg@public.gmane.org>
2015-03-31 14:05 ` [linux-nfc] " Robert Dolca
2015-05-24 17:07 ` Samuel Ortiz
2015-02-24 10:01 ` [PATCH 4/8] NFC: NCI: Add a special nci_request for driver Robert Dolca
[not found] ` <1424772112-27399-5-git-send-email-robert.dolca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-26 0:29 ` Samuel Ortiz
2015-03-31 14:07 ` [linux-nfc] " Robert Dolca
2015-02-24 10:01 ` [PATCH 5/8] NFC: NCI: Don't call setup if previous NCI request failed Robert Dolca
2015-03-26 0:29 ` Samuel Ortiz
2015-02-24 10:01 ` [PATCH 6/8] NFC: NCI: Add function to get max packet size for conn Robert Dolca
2015-02-24 10:01 ` Robert Dolca [this message]
2015-02-24 10:01 ` [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver Robert Dolca
2015-02-24 10:33 ` Johannes Berg
2015-02-24 10:46 ` Robert Dolca
2015-03-26 0:30 ` Samuel Ortiz
2015-04-01 15:35 ` [linux-nfc] " Robert Dolca
2015-05-24 17:08 ` Samuel Ortiz
2015-03-26 11:20 ` Samuel Ortiz
2015-03-26 13:45 ` Mika Westerberg
2015-02-24 16:14 ` [PATCH 0/8] Adds " Greg Rose
[not found] ` <CALgkqUqi1U1PBCndKEtdKL0n=VLvBMbOO8HTA5jt-vHvy6WBXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 16:25 ` Daniel Baluta
2015-02-24 16:27 ` Greg Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424772112-27399-8-git-send-email-robert.dolca@intel.com \
--to=robert.dolca@intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=davem@davemloft.net \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).