[PATCH net-next] i40e: mark constant as ULL

[PATCH net-next] i40e: mark constant as ULL

[Stefan Assmann]

This avoids a compile error on 32bit.

Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
 drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
index 4627588..f221ace 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
@@ -908,7 +908,7 @@ static void i40e_write_qword(u8 *hmc_bits,
 	if (ce_info->width < 64)
 		mask = ((u64)1 << ce_info->width) - 1;
 	else
-		mask = 0xFFFFFFFFFFFFFFFF;
+		mask = 0xFFFFFFFFFFFFFFFFULL;
 
 	/* don't swizzle the bits until after the mask because the mask bits
 	 * will be in a different bit position on big endian machines
-- 
2.1.0

Re: [PATCH net-next] i40e: mark constant as ULL

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
> This avoids a compile error on 32bit.
> 
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Stefan, I will add your patch to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH net-next] i40e: mark constant as ULL

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
> This avoids a compile error on 32bit.
> 
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Come to find out, I already have a fix in my queue for this.  So I will
be dropping your patch.

The patch in my queue fixes the issue by doing the folling change:
-               mask = 0xFFFFFFFFFFFFFFFF;
+               mask = ~(u64)0;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH net-next] i40e: mark constant as ULL

[Stefan Assmann]

On 04.02.2015 18:49, Jeff Kirsher wrote:
> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>> This avoids a compile error on 32bit.
>>
>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Come to find out, I already have a fix in my queue for this.  So I will
> be dropping your patch.
> 
> The patch in my queue fixes the issue by doing the folling change:
> -               mask = 0xFFFFFFFFFFFFFFFF;
> +               mask = ~(u64)0;
> 

OK.

  Stefan

Re: [PATCH net-next] i40e: mark constant as ULL

[Stefan Assmann]

On 04.02.2015 18:49, Jeff Kirsher wrote:
> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>> This avoids a compile error on 32bit.
>>
>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Come to find out, I already have a fix in my queue for this.  So I will
> be dropping your patch.
> 
> The patch in my queue fixes the issue by doing the folling change:
> -               mask = 0xFFFFFFFFFFFFFFFF;
> +               mask = ~(u64)0;
> 

Jeff,

this does not seem to compile on 32bit either. Please verify and if
you agree let's put my patch back in place instead of this one. IIRC
your patch has not been posted yet.

  Stefan

Re: [PATCH net-next] i40e: mark constant as ULL

[Stefan Assmann]

On 23.02.2015 15:56, Stefan Assmann wrote:
> On 04.02.2015 18:49, Jeff Kirsher wrote:
>> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>>> This avoids a compile error on 32bit.
>>>
>>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>>> ---
>>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Come to find out, I already have a fix in my queue for this.  So I will
>> be dropping your patch.
>>
>> The patch in my queue fixes the issue by doing the folling change:
>> -               mask = 0xFFFFFFFFFFFFFFFF;
>> +               mask = ~(u64)0;
>>
> 
> Jeff,
> 
> this does not seem to compile on 32bit either. Please verify and if
> you agree let's put my patch back in place instead of this one. IIRC
> your patch has not been posted yet.
> 
>   Stefan
> 

Jeff,

I fat fingered this, everything ok. Please ignore my last comment.

  Stefan

Re: [PATCH net-next] i40e: mark constant as ULL

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On Tue, 2015-02-24 at 13:08 +0100, Stefan Assmann wrote:
> On 23.02.2015 15:56, Stefan Assmann wrote:
> > On 04.02.2015 18:49, Jeff Kirsher wrote:
> >> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
> >>> This avoids a compile error on 32bit.
> >>>
> >>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> >>> ---
> >>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Come to find out, I already have a fix in my queue for this.  So I
> will
> >> be dropping your patch.
> >>
> >> The patch in my queue fixes the issue by doing the folling change:
> >> -               mask = 0xFFFFFFFFFFFFFFFF;
> >> +               mask = ~(u64)0;
> >>
> > 
> > Jeff,
> > 
> > this does not seem to compile on 32bit either. Please verify and if
> > you agree let's put my patch back in place instead of this one. IIRC
> > your patch has not been posted yet.
> > 
> >   Stefan
> > 
> 
> Jeff,
> 
> I fat fingered this, everything ok. Please ignore my last comment.

Ok, good to know.  I was wondering why our validation had not seen the
same issue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]