From: Madhu Challa <challa@noironetworks.com>
To: eric.dumazet@gmail.com, davem@davemloft.net,
daniel@iogearbox.net, netdev@vger.kernel.org
Cc: Madhu Challa <challa@noironetworks.com>
Subject: [PATCH net-next v5 0/2] Multicast group join/leave at ip level
Date: Wed, 25 Feb 2015 09:58:33 -0800 [thread overview]
Message-ID: <1424887115-3483-1-git-send-email-challa@noironetworks.com> (raw)
This series enables configuring multicast group join/leave at ip level
by extending the "ip address" command.
It adds a new control socket mc_autojoin_sock and ifa_flag IFA_F_MCAUTOJOIN
to invoke the corresponding igmp group join/leave api.
Since the igmp group join/leave api takes the rtnl_lock the code had to
be refactored by adding a shim layer prefixed by __ that can be invoked
by code that already has the rtnl_lock. This way we avoid proliferation of
work queues.
The first patch in this series does the refactoring for igmp v6.
Its based on igmp v4 changes that were added by Eric Dumazet.
The second patch in this series does the group join/leave based on the
setting of the IFA_F_MCAUTOJOIN flag.
v5:
- addressed comments from Daniel Borkmann.
- removed blank line in patch 1/2
- removed unused variable, const arg in patch 2/2
v4:
- addressed comments from Yoshifuji Hideaki.
- Remove WARN_ON not needed because we return a value from v2.
- addressed comments from Daniel Borkmann.
- rename sock to mc_autojoin_sk
- ip_mc_config() pass ifa so it needs one less argument.
- igmp_net_{init|destroy}() use inet_ctl_sock_{create|destroy}
- inet_rtm_newaddr() change scope of ret.
- igmp_net_init() no need to initialize sock to NULL.
v3:
- addressed comments from David Miller.
- fixed indentation and local variable order.
v2:
- addressed comments from Eric Dumazet.
- removed workqueue and call __ip_mc_{join|leave}_group or
__ipv6_sock_mc_{join|drop}
Madhu Challa (2):
igmp v6: add __ipv6_sock_mc_join and __ipv6_sock_mc_drop
multicast: Extend ip address command to enable multicast group
join/leave on
include/net/ipv6.h | 8 ++++++
include/net/netns/ipv4.h | 1 +
include/net/netns/ipv6.h | 1 +
include/uapi/linux/if_addr.h | 1 +
net/ipv4/devinet.c | 31 +++++++++++++++++++++++
net/ipv4/igmp.c | 13 ++++++++++
net/ipv6/addrconf.c | 38 +++++++++++++++++++++++++---
net/ipv6/mcast.c | 60 ++++++++++++++++++++++++++++++++++----------
8 files changed, 137 insertions(+), 16 deletions(-)
--
1.9.1
next reply other threads:[~2015-02-25 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 17:58 Madhu Challa [this message]
2015-02-25 17:58 ` [PATCH net-next v5 1/2] igmp v6: add __ipv6_sock_mc_join and __ipv6_sock_mc_drop Madhu Challa
2015-02-25 18:41 ` Eric Dumazet
2015-02-25 17:58 ` [PATCH net-next v5 2/2] multicast: Extend ip address command to enable multicast group join/leave on Madhu Challa
2015-02-27 21:26 ` [PATCH net-next v5 0/2] Multicast group join/leave at ip level David Miller
2015-03-02 12:43 ` Thomas Graf
2015-03-02 18:31 ` Madhu Challa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424887115-3483-1-git-send-email-challa@noironetworks.com \
--to=challa@noironetworks.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).