From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org, David Ertman <david.m.ertman@intel.com>
Subject: Re: [PATCH] e1000e: avoid incorrect ioremap/iounmap sequences for e1000_pch_spt
Date: Wed, 25 Feb 2015 13:24:13 -0800 [thread overview]
Message-ID: <1424899453.2622.2.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1424891492-2897-1-git-send-email-linville@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Wed, 2015-02-25 at 14:11 -0500, John W. Linville wrote:
> Commit 79849ebc0e06 (e1000e: initial support for i219) overwrites
> hw->flash_addr for e1000_pch_spt MACs without doing an iounmap.
> It also reuses the address without changing the areas that then
> iounmap the new address (which was never explicitly ioremap'ed).
> This causes iounmap to spit-out a call trace on rmmod.
>
> This patch circumvents this issue on the early hardware that we have
> in-house at Red Hat.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: David Ertman <david.m.ertman@intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks John, your patch has been added to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-02-25 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 19:11 [PATCH] e1000e: avoid incorrect ioremap/iounmap sequences for e1000_pch_spt John W. Linville
2015-02-25 21:24 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424899453.2622.2.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=david.m.ertman@intel.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox