From: Joe Perches <joe@perches.com>
To: Ian Morris <ipm@chirality.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: convert printk call to pr_err macro
Date: Thu, 26 Feb 2015 18:39:09 -0800 [thread overview]
Message-ID: <1425004749.2690.3.camel@perches.com> (raw)
In-Reply-To: <1424999650-25847-1-git-send-email-ipm@chirality.org.uk>
On Fri, 2015-02-27 at 01:14 +0000, Ian Morris wrote:
> change a printk(KERN_ERR to a pr_err macro. No changes detected by
> objdiff.
[]
> diff --git a/net/ipv6/exthdrs_core.c b/net/ipv6/exthdrs_core.c
[]
> @@ -198,7 +198,7 @@ int ipv6_find_hdr(const struct sk_buff *skb, unsigned int *offset,
>
> ip6 = skb_header_pointer(skb, *offset, sizeof(_ip6), &_ip6);
> if (!ip6 || (ip6->version != 6)) {
> - printk(KERN_ERR "IPv6 header not found\n");
> + pr_err("IPv6 header not found\n");
Hello Ian.
I presume this message is very rare, (is it even possible?)
but I also think it'd be better to use
netdev_err(skb->dev, "IPv6 header not found\n");
so that the network device can be easily identified.
prev parent reply other threads:[~2015-02-27 2:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 1:14 [PATCH net-next] ipv6: convert printk call to pr_err macro Ian Morris
2015-02-27 2:39 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425004749.2690.3.camel@perches.com \
--to=joe@perches.com \
--cc=ipm@chirality.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).