From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: neerav.parikh@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [net-next 09/18] i40e/i40evf: Add capability to gather VEB per TC stats
Date: Mon, 02 Mar 2015 17:34:12 -0800 [thread overview]
Message-ID: <1425346452.2556.1.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20150228.233043.1806944010152525182.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Sat, 2015-02-28 at 23:30 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 28 Feb 2015 03:29:40 -0800
>
> > From: Neerav Parikh <neerav.parikh@intel.com>
> >
> > This patch adds capability to update per VEB per TC statistics and dump
> > it via debugfs. It also adds a structure to hold VEB per TC statistics.
> > The fields can be filled by reading the GLVEBTC_* counters.
> >
> > Change-ID: I45cca003d8b12d96951a67f50d5dd7a789e09218
> > Signed-off-by: Neerav Parikh <neerav.parikh@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> For the umpteenth time, stop dumping statistics into debugfs.
>
> Export them like any other statistic, via ethtool.
>
> This applies to the existing debugfs you're building on top
> of in this change as well, I very much regret not catching
> that when it initially went in.
>
> Please stop, in general, using debugfs as a dumping ground
> for thing you can't initially figure out how to export via
> normal standard interfaces.
Sorry that slipped by me as well, my fault for not catching it and
pushing back on the developer for putting this into ethtool stats.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-03 1:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 11:29 [net-next 00/18][pull request] Intel Wired LAN Driver Updates 2015-02-28 Jeff Kirsher
2015-02-28 11:29 ` [net-next 01/18] fm10k: Modify tunnel length header check when offloading Jeff Kirsher
2015-02-28 11:29 ` [net-next 02/18] fm10k: Implement ndo_features_check Jeff Kirsher
2015-02-28 11:29 ` [net-next 03/18] fm10k: Resolve various spelling errors and checkpatch warnings Jeff Kirsher
2015-02-28 11:29 ` [net-next 04/18] i40e: Skip the priority tagging if DCB is not enabled Jeff Kirsher
2015-02-28 11:29 ` [net-next 05/18] i40e/i40evf: print FW build number in version string Jeff Kirsher
2015-02-28 11:29 ` [net-next 06/18] i40e: Add safety net for switch calling Jeff Kirsher
2015-02-28 11:29 ` [net-next 07/18] i40e: don't disable PF LB when disabling VFs Jeff Kirsher
2015-02-28 11:29 ` [net-next 08/18] i40e: Enable more than 64 qps for the Main VSI Jeff Kirsher
2015-02-28 11:29 ` [net-next 09/18] i40e/i40evf: Add capability to gather VEB per TC stats Jeff Kirsher
2015-03-01 4:30 ` David Miller
2015-03-03 1:34 ` Jeff Kirsher [this message]
2015-02-28 11:29 ` [net-next 10/18] i40e: Add FW check to disable DCB and wrap autoneg workaround with FW check Jeff Kirsher
2015-02-28 11:29 ` [net-next 11/18] i40e: Fix issue with removal of apps from DBCNL app table Jeff Kirsher
2015-02-28 11:29 ` [net-next 12/18] i40e/i40evf: Add missing packet types for VXLAN encapsulated packet types Jeff Kirsher
2015-02-28 11:29 ` [net-next 13/18] i40e: Move RSS table size for VSIs to the VSI struct Jeff Kirsher
2015-02-28 11:29 ` [net-next 14/18] i40e: Fix RSS size at init since default num queue calculation has changed Jeff Kirsher
2015-02-28 11:29 ` [net-next 15/18] i40evf: ethtool RSS fixes Jeff Kirsher
2015-02-28 11:29 ` [net-next 16/18] i40e: Register DCBNL ops in MFP mode Jeff Kirsher
2015-02-28 11:29 ` [net-next 17/18] i40e: Only enable TC0 for NIC partition type Jeff Kirsher
2015-02-28 11:29 ` [net-next 18/18] i40e/i40evf: Bump versions Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425346452.2556.1.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=neerav.parikh@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).