From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code Date: Tue, 03 Mar 2015 11:07:51 -0800 Message-ID: <1425409671.17273.42.camel@perches.com> References: <1425388752.5130.164.camel@edumazet-glaptop2.roam.corp.google.com> <1425407104.17273.27.camel@perches.com> <1425408125.5130.191.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Eric Dumazet Return-path: In-Reply-To: <1425408125.5130.191.camel@edumazet-glaptop2.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: > On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > > > At least for arm gcc 4.6.3, it emits different code > > for net/l2tp/l2tp_eth.o > > Then it looks like arm gcc or arm linux memset() should be improved. Perhaps you can take that up with the gcc folk. I think it appropriate to improve the actual emitted code for the compiler I use. (it seems this code isn't fast-path anywhere though) > Tracking all memset(x, y, 6) and replace them by some custom version > seems not very generic to me, when something better can be done. There's the same argument for the ether_addr_equal and ether_addr_copy functions. iow: memcmp, memcpy too cheers, Joe