* [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline
@ 2015-03-06 16:44 Willem de Bruijn
2015-03-06 20:31 ` Scott Feldman
2015-03-06 20:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Willem de Bruijn @ 2015-03-06 16:44 UTC (permalink / raw)
To: netdev; +Cc: davem, sfeldma, alexander.duyck, Willem de Bruijn
From: Willem de Bruijn <willemb@google.com>
When building without CONFIG_NET_SWITCHDEV,
netdev_switch_fib_ipv4_abort is defined in the header file. It must
be static inline to avoid build failure at link time.
Fixes: 8e05fd7166c6 ("fib: hook IPv4 fib for hardware offload")
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
include/net/switchdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index dc0a5cc..933fac4 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -129,7 +129,7 @@ static inline int netdev_switch_fib_ipv4_del(u32 dst, int dst_len,
return 0;
}
-void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
+static inline void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
{
}
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline
2015-03-06 16:44 [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline Willem de Bruijn
@ 2015-03-06 20:31 ` Scott Feldman
2015-03-06 20:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Scott Feldman @ 2015-03-06 20:31 UTC (permalink / raw)
To: Willem de Bruijn; +Cc: Netdev, David S. Miller, Alexander Duyck
On Fri, Mar 6, 2015 at 8:44 AM, Willem de Bruijn <willemb@google.com> wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> When building without CONFIG_NET_SWITCHDEV,
> netdev_switch_fib_ipv4_abort is defined in the header file. It must
> be static inline to avoid build failure at link time.
>
> Fixes: 8e05fd7166c6 ("fib: hook IPv4 fib for hardware offload")
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
> ---
> include/net/switchdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index dc0a5cc..933fac4 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -129,7 +129,7 @@ static inline int netdev_switch_fib_ipv4_del(u32 dst, int dst_len,
> return 0;
> }
>
> -void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
> +static inline void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
> {
> }
Acked-by: Scott Feldman <sfeldma@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline
2015-03-06 16:44 [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline Willem de Bruijn
2015-03-06 20:31 ` Scott Feldman
@ 2015-03-06 20:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-03-06 20:44 UTC (permalink / raw)
To: willemb; +Cc: netdev, sfeldma, alexander.duyck
From: Willem de Bruijn <willemb@google.com>
Date: Fri, 6 Mar 2015 11:44:28 -0500
> From: Willem de Bruijn <willemb@google.com>
>
> When building without CONFIG_NET_SWITCHDEV,
> netdev_switch_fib_ipv4_abort is defined in the header file. It must
> be static inline to avoid build failure at link time.
>
> Fixes: 8e05fd7166c6 ("fib: hook IPv4 fib for hardware offload")
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied, thanks Willem.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-06 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-06 16:44 [PATCH net-next] fib: make netdev_switch_fib_ipv4_abort in header file static inline Willem de Bruijn
2015-03-06 20:31 ` Scott Feldman
2015-03-06 20:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).