From: Yongbae Park <yongbae2@gmail.com>
To: anton@au.ibm.com, larson1@us.ibm.com, santil@linux.vnet.ibm.com,
brking@linux.vnet.ibm.com, rcj@linux.vnet.ibm.com
Cc: ebiederm@xmission.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH] ibmveth: enable interrupts after napi_complete()
Date: Tue, 10 Mar 2015 11:15:19 +0900 [thread overview]
Message-ID: <1425953719-30110-1-git-send-email-yongbae2@gmail.com> (raw)
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
next reply other threads:[~2015-03-10 2:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 2:15 Yongbae Park [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-10 2:15 [PATCH] ibmveth: enable interrupts after napi_complete() Yongbae Park
2015-03-10 2:38 ` David Miller
2015-03-10 4:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425953719-30110-1-git-send-email-yongbae2@gmail.com \
--to=yongbae2@gmail.com \
--cc=anton@au.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=larson1@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox