netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
	Kalle Valo <kvalo@qca.qualcomm.com>,
	Valdis.Kletnieks@vt.edu, Bj??rn Mork <bjorn@mork.no>,
	Jeff Haran <Jeff.Haran@citrix.com>,
	Pat Erley <pat-lkml@erley.org>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function
Date: Wed, 11 Mar 2015 20:22:41 +0100	[thread overview]
Message-ID: <1426101761.1904.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20150311191526.GA24455@opentech.at>

On Wed, 2015-03-11 at 20:15 +0100, Nicholas Mc Guire wrote:

> I'm not into this long enough to say what is better and if the consensus
> is that this patch is no more readable than the original code
> and no more maintainable either, then it is not worth the effort.

Personally, I like the change, it might even make that function more
reusable etc., and it gets rid of the ({ ... }) expression syntax which
I always find a bit odd :)

johannes

  reply	other threads:[~2015-03-11 19:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 19:01 [PATCH RFC v2] ath10k: move code from parameter list into a function Nicholas Mc Guire
2015-03-11 19:10 ` Johannes Berg
2015-03-11 19:15   ` Nicholas Mc Guire
2015-03-11 19:22     ` Johannes Berg [this message]
2015-03-11 20:29 ` Sergei Shtylyov
2015-03-12  7:32   ` Nicholas Mc Guire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426101761.1904.10.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Jeff.Haran@citrix.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=ath10k@lists.infradead.org \
    --cc=bjorn@mork.no \
    --cc=der.herr@hofr.at \
    --cc=hofrat@osadl.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pat-lkml@erley.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).