From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function Date: Wed, 11 Mar 2015 20:22:41 +0100 Message-ID: <1426101761.1904.10.camel@sipsolutions.net> References: <1426100519-20636-1-git-send-email-hofrat@osadl.org> <1426101010.1904.9.camel@sipsolutions.net> <20150311191526.GA24455@opentech.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Nicholas Mc Guire , Kalle Valo , Valdis.Kletnieks@vt.edu, Bj??rn Mork , Jeff Haran , Pat Erley , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Nicholas Mc Guire Return-path: In-Reply-To: <20150311191526.GA24455@opentech.at> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2015-03-11 at 20:15 +0100, Nicholas Mc Guire wrote: > I'm not into this long enough to say what is better and if the consensus > is that this patch is no more readable than the original code > and no more maintainable either, then it is not worth the effort. Personally, I like the change, it might even make that function more reusable etc., and it gets rid of the ({ ... }) expression syntax which I always find a bit odd :) johannes