* [PATCH 0/1] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi
@ 2015-03-14 0:55 Alexandru M Stan
[not found] ` <1426294532-32078-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alexandru M Stan @ 2015-03-14 0:55 UTC (permalink / raw)
To: heiko, roger.chen
Cc: dianders, peppe.cavallaro, netdev, linux-kernel, linux-rockchip,
kever.yang, eddie.cai, Alexandru M Stan, Russell King, devicetree,
Kumar Gala, Ian Campbell, Rob Herring, Pawel Moll, Mark Rutland,
linux-arm-kernel
The way it is right now, each board using rk3288.dtsi has to disable
it or else (given CONFIG_DWMAC_RK is set) it will try loading the driver
and looking for phy's even though none are connected.
The status should be "disabled".
PS: I'm ok with "the big relicensing"
(http://www.spinics.net/lists/arm-kernel/msg403629.html) to GPLv2/X11.
Alexandru M Stan (1):
ARM: dts: rockchip: disable gmac by default in rk3288.dtsi
arch/arm/boot/dts/rk3288.dtsi | 1 +
1 file changed, 1 insertion(+)
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1426294532-32078-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]
* [PATCH] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi [not found] ` <1426294532-32078-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> @ 2015-03-14 0:55 ` Alexandru M Stan 2015-03-14 18:40 ` Heiko Stuebner 0 siblings, 1 reply; 3+ messages in thread From: Alexandru M Stan @ 2015-03-14 0:55 UTC (permalink / raw) To: heiko-4mtYJXux2i+zQB+pC5nmwQ, roger.chen-TNX95d0MmH7DzftRWevZcw Cc: dianders-F7+t8E8rja9g9hUCZPvPmw, peppe.cavallaro-qxv4g6HH51o, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, kever.yang-TNX95d0MmH7DzftRWevZcw, eddie.cai-TNX95d0MmH7DzftRWevZcw, Alexandru M Stan, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA This block should not be enabled by default or else if the kconfig is set, it will try to load/probe even if there's no phy connected. Signed-off-by: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> --- arch/arm/boot/dts/rk3288.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index d771f68..eccc78d 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -411,6 +411,7 @@ "mac_clk_rx", "mac_clk_tx", "clk_mac_ref", "clk_mac_refout", "aclk_mac", "pclk_mac"; + status = "disabled"; }; usb_host0_ehci: usb@ff500000 { -- 2.2.0.rc0.207.ga3a616c -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi 2015-03-14 0:55 ` [PATCH] " Alexandru M Stan @ 2015-03-14 18:40 ` Heiko Stuebner 0 siblings, 0 replies; 3+ messages in thread From: Heiko Stuebner @ 2015-03-14 18:40 UTC (permalink / raw) To: Alexandru M Stan Cc: roger.chen, dianders, peppe.cavallaro, netdev, linux-kernel, linux-rockchip, kever.yang, eddie.cai, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, devicetree Am Freitag, 13. März 2015, 17:55:32 schrieb Alexandru M Stan: > This block should not be enabled by default or else if the kconfig is set, > it will try to load/probe even if there's no phy connected. > > Signed-off-by: Alexandru M Stan <amstan@chromium.org> applied to my fixes branch Thanks Heiko > --- > arch/arm/boot/dts/rk3288.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index d771f68..eccc78d 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -411,6 +411,7 @@ > "mac_clk_rx", "mac_clk_tx", > "clk_mac_ref", "clk_mac_refout", > "aclk_mac", "pclk_mac"; > + status = "disabled"; > }; > > usb_host0_ehci: usb@ff500000 { ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-14 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-14 0:55 [PATCH 0/1] ARM: dts: rockchip: disable gmac by default in rk3288.dtsi Alexandru M Stan
[not found] ` <1426294532-32078-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2015-03-14 0:55 ` [PATCH] " Alexandru M Stan
2015-03-14 18:40 ` Heiko Stuebner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).