From: Baolin Wang <baolin.wang@linaro.org>
To: richardcochran@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.com, tglx@linutronix.de, arnd@linaro.org,
baolin.wang@linaro.org
Subject: [PATCH 3/4] ptp/pch:Replace timespec with ktime_t in ptp_pch.c
Date: Thu, 19 Mar 2015 13:45:08 +0800 [thread overview]
Message-ID: <1426743909-24335-4-git-send-email-baolin.wang@linaro.org> (raw)
In-Reply-To: <1426743909-24335-1-git-send-email-baolin.wang@linaro.org>
This patch changes the 32-bit time type (timespec) to the 64-bit one
(ktime_t), since 32-bit time types will break in the year 2038.
This patch implements the getktime/setktime interfaces with
"ktime_t" type, and removed the gettime/settime interfaces with
"timespec" type in ptp_pch.c file.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/ptp/ptp_pch.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index 2554872..c759225 100644
--- a/drivers/ptp/ptp_pch.c
+++ b/drivers/ptp/ptp_pch.c
@@ -449,36 +449,27 @@ static int ptp_pch_adjtime(struct ptp_clock_info *ptp, s64 delta)
return 0;
}
-static int ptp_pch_gettime(struct ptp_clock_info *ptp, struct timespec *ts)
+static int ptp_pch_getktime(struct ptp_clock_info *ptp, ktime_t *kt)
{
- u64 ns;
- u32 remainder;
unsigned long flags;
struct pch_dev *pch_dev = container_of(ptp, struct pch_dev, caps);
struct pch_ts_regs __iomem *regs = pch_dev->regs;
spin_lock_irqsave(&pch_dev->register_lock, flags);
- ns = pch_systime_read(regs);
+ *kt = ns_to_ktime(pch_systime_read(regs));
spin_unlock_irqrestore(&pch_dev->register_lock, flags);
- ts->tv_sec = div_u64_rem(ns, 1000000000, &remainder);
- ts->tv_nsec = remainder;
return 0;
}
-static int ptp_pch_settime(struct ptp_clock_info *ptp,
- const struct timespec *ts)
+static int ptp_pch_setktime(struct ptp_clock_info *ptp, ktime_t kt)
{
- u64 ns;
unsigned long flags;
struct pch_dev *pch_dev = container_of(ptp, struct pch_dev, caps);
struct pch_ts_regs __iomem *regs = pch_dev->regs;
- ns = ts->tv_sec * 1000000000ULL;
- ns += ts->tv_nsec;
-
spin_lock_irqsave(&pch_dev->register_lock, flags);
- pch_systime_write(regs, ns);
+ pch_systime_write(regs, ktime_to_ns(kt));
spin_unlock_irqrestore(&pch_dev->register_lock, flags);
return 0;
@@ -518,8 +509,8 @@ static struct ptp_clock_info ptp_pch_caps = {
.pps = 0,
.adjfreq = ptp_pch_adjfreq,
.adjtime = ptp_pch_adjtime,
- .gettime = ptp_pch_gettime,
- .settime = ptp_pch_settime,
+ .getktime = ptp_pch_getktime,
+ .setktime = ptp_pch_setktime,
.enable = ptp_pch_enable,
};
--
1.7.9.5
next prev parent reply other threads:[~2015-03-19 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:45 [PATCH 0/4] Introduce another options to set/get time with "ktime_t" type Baolin Wang
2015-03-19 5:45 ` [PATCH 1/4] ptp/chardev:Introduce another option to get/set time in ptp_clock_info structure Baolin Wang
2015-03-19 7:48 ` Richard Cochran
2015-03-19 5:45 ` [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Baolin Wang
2015-03-19 7:54 ` Richard Cochran
[not found] ` <CAMz4kuKyDFCqd-LfoSKJf+tkXdzzLwtPJdp-nF6NbKU8W5HHpQ@mail.gmail.com>
2015-03-20 6:26 ` Richard Cochran
2015-03-20 13:43 ` Arnd Bergmann
2015-03-20 16:49 ` Richard Cochran
2015-03-21 1:16 ` Arnd Bergmann
2015-03-21 7:24 ` Richard Cochran
2015-03-21 16:52 ` Richard Cochran
2015-03-22 2:47 ` Arnd Bergmann
2015-03-21 9:21 ` Richard Cochran
2015-03-19 5:45 ` Baolin Wang [this message]
2015-03-19 5:45 ` [PATCH 4/4] ptp/ixp46x:Replace timespec with ktime_t in ptp_ixp46x.c Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426743909-24335-4-git-send-email-baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=arnd@linaro.org \
--cc=john.stultz@linaro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).