From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de, Andri Yngvason <andri.yngvason@marel.com>,
linux-stable <stable@vger.kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 6/7] can: flexcan: fix bus-off error state handling.
Date: Sun, 22 Mar 2015 20:13:37 +0100 [thread overview]
Message-ID: <1427051618-28318-7-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1427051618-28318-1-git-send-email-mkl@pengutronix.de>
From: Andri Yngvason <andri.yngvason@marel.com>
Making sure that the bus-off state gets passed to can_change_state().
Signed-off-by: Andri Yngvason <andri.yngvason@marel.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/flexcan.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 80c46ad4cee4..ee944ae6bb96 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -592,13 +592,12 @@ static int flexcan_poll_state(struct net_device *dev, u32 reg_esr)
rx_state = unlikely(reg_esr & FLEXCAN_ESR_RX_WRN) ?
CAN_STATE_ERROR_WARNING : CAN_STATE_ERROR_ACTIVE;
new_state = max(tx_state, rx_state);
- } else if (unlikely(flt == FLEXCAN_ESR_FLT_CONF_PASSIVE)) {
+ } else {
__flexcan_get_berr_counter(dev, &bec);
- new_state = CAN_STATE_ERROR_PASSIVE;
+ new_state = flt == FLEXCAN_ESR_FLT_CONF_PASSIVE ?
+ CAN_STATE_ERROR_PASSIVE : CAN_STATE_BUS_OFF;
rx_state = bec.rxerr >= bec.txerr ? new_state : 0;
tx_state = bec.rxerr <= bec.txerr ? new_state : 0;
- } else {
- new_state = CAN_STATE_BUS_OFF;
}
/* state hasn't changed */
--
2.1.4
next prev parent reply other threads:[~2015-03-22 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 19:13 pull-request: can 2015-03-22 Marc Kleine-Budde
2015-03-22 19:13 ` [PATCH 1/7] can: kvaser_usb: Comply with firmware max tx URBs value Marc Kleine-Budde
2015-03-22 19:13 ` [PATCH 2/7] can: kvaser_usb: Fix sparse warning __le16 degrades to integer Marc Kleine-Budde
2015-03-22 19:13 ` [PATCH 3/7] can: gs_usb: check for kzalloc allocation failure Marc Kleine-Budde
2015-03-22 19:13 ` [PATCH 4/7] can: peak_usb: rename usb option cmds definition and structs Marc Kleine-Budde
2015-03-22 19:13 ` [PATCH 5/7] can: peak_usb_fd: add support for ISO / non-ISO mode switching Marc Kleine-Budde
2015-03-22 19:13 ` Marc Kleine-Budde [this message]
2015-03-22 19:13 ` [PATCH 7/7] can: flexcan: Deferred on Regulator return EPROBE_DEFER Marc Kleine-Budde
2015-03-24 2:36 ` pull-request: can 2015-03-22 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427051618-28318-7-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andri.yngvason@marel.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).