netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "D. S. Ljungmark" <spider@takeit.se>
To: netdev@vger.kernel.org
Subject: ipv6 : Don't reduce hop limit below current value
Date: Tue, 24 Mar 2015 22:36:09 +0100	[thread overview]
Message-ID: <1427232969.3276.4.camel@takeit.se> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 101 bytes --]

A local route may have a lower hop_limit set than global routes do.


See RFC 3756 Section 4.2.7

[-- Attachment #1.2: 0001-ipv6-Don-t-reduce-hop-limit-for-an-interface.patch --]
[-- Type: text/x-patch, Size: 1252 bytes --]

From 846e648ac8ea9325778a61038a09d98c2fb7002a Mon Sep 17 00:00:00 2001
From: "D.S. Ljungmark" <spider@skuggor.se>
Date: Tue, 24 Mar 2015 22:18:47 +0100
Subject: [PATCH] ipv6: Don't reduce hop limit for an interface

A local route may have a lower hop_limit set than global routes do.
See RFC 3756 Section 4.2.7

Signed-off-by: D.S. Ljungmark <ljungmark@modio.se>
---
 net/ipv6/ndisc.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 471ed24..b939652 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1218,7 +1218,14 @@ static void ndisc_router_discovery(struct sk_buff *skb)
 	if (rt)
 		rt6_set_expires(rt, jiffies + (HZ * lifetime));
 	if (ra_msg->icmph.icmp6_hop_limit) {
-		in6_dev->cnf.hop_limit = ra_msg->icmph.icmp6_hop_limit;
+		/*	Only set hop_limit on the interface if it is higher than
+		*	the current hop_limit.
+		 */
+		if (in6_dev->cnf.hop_limit < ra_msg->icmph.icmp6_hop_limit) {
+			in6_dev->cnf.hop_limit = ra_msg->icmph.icmp6_hop_limit;
+		} else {
+			ND_PRINTK(2, warn, "RA: Got route advertisement with lower hop_limit than current\n");
+		}
 		if (rt)
 			dst_metric_set(&rt->dst, RTAX_HOPLIMIT,
 				       ra_msg->icmph.icmp6_hop_limit);
-- 
2.1.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2015-03-24 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 21:36 D. S. Ljungmark [this message]
2015-03-24 22:06 ` ipv6 : Don't reduce hop limit below current value David Miller
2015-03-24 23:36   ` D. S. Ljungmark
2015-03-25  1:20     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427232969.3276.4.camel@takeit.se \
    --to=spider@takeit.se \
    --cc=ljungmark@modio.se \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).