netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Subject: [Patch net 2/2] ipmr,ip6mr: call list_del_rcu() when deleting mr table from list
Date: Wed, 25 Mar 2015 12:05:45 -0700	[thread overview]
Message-ID: <1427310345-29829-2-git-send-email-xiyou.wangcong@gmail.com> (raw)
In-Reply-To: <1427310345-29829-1-git-send-email-xiyou.wangcong@gmail.com>

Probably not a big deal, just for corretness.

Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
 net/ipv4/ipmr.c  | 2 +-
 net/ipv6/ip6mr.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index d6fede8..68f67b8 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -280,7 +280,7 @@ static void __net_exit ipmr_rules_exit(struct net *net)
 
 	rtnl_lock();
 	list_for_each_entry_safe(mrt, next, &net->ipv4.mr_tables, list) {
-		list_del(&mrt->list);
+		list_del_rcu(&mrt->list);
 		ipmr_free_table(mrt);
 	}
 	rtnl_unlock();
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 34b6826..3df1ec2 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -264,7 +264,7 @@ static void __net_exit ip6mr_rules_exit(struct net *net)
 
 	rtnl_lock();
 	list_for_each_entry_safe(mrt, next, &net->ipv6.mr6_tables, list) {
-		list_del(&mrt->list);
+		list_del_rcu(&mrt->list);
 		ip6mr_free_table(mrt);
 	}
 	rtnl_unlock();
-- 
1.8.3.1

  reply	other threads:[~2015-03-25 19:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 19:05 [Patch net 1/2] ipv4: take rtnl_lock and mark mrt table as freed on namespace cleanup Cong Wang
2015-03-25 19:05 ` Cong Wang [this message]
2015-03-25 20:07   ` [Patch net 2/2] ipmr,ip6mr: call list_del_rcu() when deleting mr table from list Hannes Frederic Sowa
2015-03-25 20:21     ` Hannes Frederic Sowa
2015-03-25 20:56       ` Hannes Frederic Sowa
2015-03-25 22:33         ` Cong Wang
2015-03-26  1:01           ` Hannes Frederic Sowa
2015-03-26 12:23             ` Hannes Frederic Sowa
2015-03-31  0:17               ` Cong Wang
2015-03-25 20:23 ` [Patch net 1/2] ipv4: take rtnl_lock and mark mrt table as freed on namespace cleanup Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427310345-29829-2-git-send-email-xiyou.wangcong@gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).