From: roy.qing.li@gmail.com
To: netdev@vger.kernel.org, alexander.h.duyck@redhat.com
Subject: [PATCH] net: fix two possible memory leaks in netif_set_xps_queue
Date: Thu, 26 Mar 2015 15:40:43 +0800 [thread overview]
Message-ID: <1427355643-10422-1-git-send-email-roy.qing.li@gmail.com> (raw)
From: Li RongQing <roy.qing.li@gmail.com>
new_dev_maps->cpu_map[cpu] maybe be assigned to the memory from
expand_xps_map() in the first loop, so should be freed
when free dev_maps, make sure to free new_dev_maps->cpu_map[cpu]
firstly
Fixes: 537c00de1c [net: Add functions netif_reset_xps_queue and netif_set_xps_queue]
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
net/core/dev.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 5d43e01..aa6459f 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2025,9 +2025,11 @@ int netif_set_xps_queue(struct net_device *dev, const struct cpumask *mask,
} else if (dev_maps) {
/* fill in the new device map from the old device map */
map = xmap_dereference(dev_maps->cpu_map[cpu]);
+ new_map = xmap_dereference(new_dev_maps->cpu_map[cpu]);
RCU_INIT_POINTER(new_dev_maps->cpu_map[cpu], map);
+ if (new_map && map != new_map)
+ kfree_rcu(new_map, rcu);
}
-
}
rcu_assign_pointer(dev->xps_maps, new_dev_maps);
@@ -2068,6 +2070,13 @@ out_no_new_maps:
/* free map if not active */
if (!active) {
RCU_INIT_POINTER(dev->xps_maps, NULL);
+
+ for_each_possible_cpu(cpu) {
+ map = xmap_dereference(dev_maps->cpu_map[cpu]);
+ if (map)
+ kfree_rcu(map, rcu);
+ }
+
kfree_rcu(dev_maps, rcu);
}
--
2.1.0
next reply other threads:[~2015-03-26 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 7:40 roy.qing.li [this message]
2015-03-26 18:15 ` [PATCH] net: fix two possible memory leaks in netif_set_xps_queue Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427355643-10422-1-git-send-email-roy.qing.li@gmail.com \
--to=roy.qing.li@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).