netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 13/16] net: dsa: Centralise getting switch id
Date: Thu, 26 Mar 2015 18:36:40 -0700	[thread overview]
Message-ID: <1427420203-27685-14-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1427420203-27685-1-git-send-email-linux@roeck-us.net>

From: Andrew Lunn <andrew@lunn.ch>

Get the switch id and save it away in the private mv88x6xxx structure
in a centralised piece of code, rather than each driver doing it itself.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/net/dsa/mv88e6352.c | 2 --
 drivers/net/dsa/mv88e6xxx.c | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c
index 7285bd053363..41fe3a6a72d1 100644
--- a/drivers/net/dsa/mv88e6352.c
+++ b/drivers/net/dsa/mv88e6352.c
@@ -369,8 +369,6 @@ static int mv88e6352_setup(struct dsa_switch *ds)
 
 	mutex_init(&ps->eeprom_mutex);
 
-	ps->id = REG_READ(REG_PORT(0), 0x03) & 0xfff0;
-
 	ret = mv88e6352_switch_reset(ds);
 	if (ret < 0)
 		return ret;
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 038802229e32..13572cc24c6d 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -1152,6 +1152,8 @@ int mv88e6xxx_setup_common(struct dsa_switch *ds)
 	mutex_init(&ps->stats_mutex);
 	mutex_init(&ps->phy_mutex);
 
+	ps->id = REG_READ(REG_PORT(0), 0x03) & 0xfff0;
+
 	ps->fid_mask = (1 << DSA_MAX_PORTS) - 1;
 
 	INIT_WORK(&ps->bridge_work, mv88e6xxx_bridge_work);
-- 
2.1.0

  parent reply	other threads:[~2015-03-27  1:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  1:36 [PATCH v2 00/16] net: dsa: HW bridging, EEE support Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 01/16] net: dsa: mv88e6xxx: Factor out common initialization code Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 02/16] net: dsa: mv88e6xxx: Provide function for common port initialization Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 03/16] net: dsa: mv88e6xxx: Disable Message Port bit for CPU port Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 04/16] net: dsa: mv88e6xxx: Split mv88e6xxx_reg_read and mv88e6xxx_reg_write Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 05/16] net: dsa: mv88e6352: Use common port initialization code Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 06/16] net: dsa: mv88e6123_61_65: Use common port configuration Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 07/16] net: dsa: mv88e6171: " Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 08/16] net: dsa: mv88e6xxx: Add Hardware bridging support Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 09/16] net: dsa: mv88e6352: Add support for hardware bridging Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 10/16] net: dsa: Add basic framework to support ndo_fdb functions Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 11/16] net: dsa: mv88e6xxx: Add support for fdb_add, fdb_del, and fdb_getnext Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 12/16] net: dsa: mv88e6352: Add support for ndo_fdb functions Guenter Roeck
2015-03-27  1:36 ` Guenter Roeck [this message]
2015-03-27  1:36 ` [PATCH v2 14/16] net: dsa: mv88e6171: Add defines for switch product IDs Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 15/16] net: dsa: mv88e6171: Add EEE support to the mv88e6172 Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 16/16] net: dsa: mv88e6171: Add support for hardware bridging Guenter Roeck
2015-03-27  6:01 ` [PATCH v2 00/16] net: dsa: HW bridging, EEE support Florian Fainelli
2015-03-27 15:54 ` Andrew Lunn
2015-03-29 20:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427420203-27685-14-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).