netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 06/16] net: dsa: mv88e6123_61_65: Use common port configuration
Date: Thu, 26 Mar 2015 18:36:33 -0700	[thread overview]
Message-ID: <1427420203-27685-7-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1427420203-27685-1-git-send-email-linux@roeck-us.net>

This will simplify adding offloaded bridge support later on.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/net/dsa/mv88e6123_61_65.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/drivers/net/dsa/mv88e6123_61_65.c b/drivers/net/dsa/mv88e6123_61_65.c
index 6ebe57044afc..2d7e1ffe9fdc 100644
--- a/drivers/net/dsa/mv88e6123_61_65.c
+++ b/drivers/net/dsa/mv88e6123_61_65.c
@@ -222,28 +222,6 @@ static int mv88e6123_61_65_setup_port(struct dsa_switch *ds, int p)
 		val |= 0x000c;
 	REG_WRITE(addr, 0x04, val);
 
-	/* Port Control 1: disable trunking.  Also, if this is the
-	 * CPU port, enable learn messages to be sent to this port.
-	 */
-	REG_WRITE(addr, 0x05, dsa_is_cpu_port(ds, p) ? 0x8000 : 0x0000);
-
-	/* Port based VLAN map: give each port its own address
-	 * database, allow the CPU port to talk to each of the 'real'
-	 * ports, and allow each of the 'real' ports to only talk to
-	 * the upstream port.
-	 */
-	val = (p & 0xf) << 12;
-	if (dsa_is_cpu_port(ds, p))
-		val |= ds->phys_port_mask;
-	else
-		val |= 1 << dsa_upstream_port(ds);
-	REG_WRITE(addr, 0x06, val);
-
-	/* Default VLAN ID and priority: don't set a default VLAN
-	 * ID, and set the default packet priority to zero.
-	 */
-	REG_WRITE(addr, 0x07, 0x0000);
-
 	/* Port Control 2: don't force a good FCS, set the maximum
 	 * frame size to 10240 bytes, don't let the switch add or
 	 * strip 802.1q tags, don't discard tagged or untagged frames
@@ -288,7 +266,7 @@ static int mv88e6123_61_65_setup_port(struct dsa_switch *ds, int p)
 	 */
 	REG_WRITE(addr, 0x19, 0x7654);
 
-	return 0;
+	return mv88e6xxx_setup_port_common(ds, p);
 }
 
 static int mv88e6123_61_65_setup(struct dsa_switch *ds)
-- 
2.1.0

  parent reply	other threads:[~2015-03-27  1:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  1:36 [PATCH v2 00/16] net: dsa: HW bridging, EEE support Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 01/16] net: dsa: mv88e6xxx: Factor out common initialization code Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 02/16] net: dsa: mv88e6xxx: Provide function for common port initialization Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 03/16] net: dsa: mv88e6xxx: Disable Message Port bit for CPU port Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 04/16] net: dsa: mv88e6xxx: Split mv88e6xxx_reg_read and mv88e6xxx_reg_write Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 05/16] net: dsa: mv88e6352: Use common port initialization code Guenter Roeck
2015-03-27  1:36 ` Guenter Roeck [this message]
2015-03-27  1:36 ` [PATCH v2 07/16] net: dsa: mv88e6171: Use common port configuration Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 08/16] net: dsa: mv88e6xxx: Add Hardware bridging support Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 09/16] net: dsa: mv88e6352: Add support for hardware bridging Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 10/16] net: dsa: Add basic framework to support ndo_fdb functions Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 11/16] net: dsa: mv88e6xxx: Add support for fdb_add, fdb_del, and fdb_getnext Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 12/16] net: dsa: mv88e6352: Add support for ndo_fdb functions Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 13/16] net: dsa: Centralise getting switch id Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 14/16] net: dsa: mv88e6171: Add defines for switch product IDs Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 15/16] net: dsa: mv88e6171: Add EEE support to the mv88e6172 Guenter Roeck
2015-03-27  1:36 ` [PATCH v2 16/16] net: dsa: mv88e6171: Add support for hardware bridging Guenter Roeck
2015-03-27  6:01 ` [PATCH v2 00/16] net: dsa: HW bridging, EEE support Florian Fainelli
2015-03-27 15:54 ` Andrew Lunn
2015-03-29 20:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427420203-27685-7-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).