* [PATCH net 0/1] af_iucv: fix AF_IUCV sendmsg() errno
@ 2015-03-30 13:40 Ursula Braun
2015-03-30 13:40 ` [PATCH net 1/1] " Ursula Braun
0 siblings, 1 reply; 3+ messages in thread
From: Ursula Braun @ 2015-03-30 13:40 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, ursula.braun, ubraun
From: Ursula Braun <ursula.braun@de.ibm.com>
Hi Dave,
here is a small patch for net fixing a bug in s390 net/iucv/af_iucv.c
shortlog:
Eugene Crosser (1):
af_iucv: fix AF_IUCV sendmsg() errno
Thanks,
Ursula
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH net 1/1] af_iucv: fix AF_IUCV sendmsg() errno 2015-03-30 13:40 [PATCH net 0/1] af_iucv: fix AF_IUCV sendmsg() errno Ursula Braun @ 2015-03-30 13:40 ` Ursula Braun 2015-03-31 20:07 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Ursula Braun @ 2015-03-30 13:40 UTC (permalink / raw) To: davem; +Cc: netdev, linux-s390, ursula.braun, ubraun, Eugene Crosser From: Eugene Crosser <Eugene.Crosser@ru.ibm.com> When sending over AF_IUCV socket, errno was incorrectly set to ENOMEM even when other values where appropriate, notably EAGAIN. With this patch, error indicator returned by sock_alloc_send_skb() is passed to the caller, rather than being overwritten with ENOMEM. Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> --- net/iucv/af_iucv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 2e9953b..53d9311 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -1114,10 +1114,8 @@ static int iucv_sock_sendmsg(struct kiocb *iocb, struct socket *sock, noblock, &err); else skb = sock_alloc_send_skb(sk, len, noblock, &err); - if (!skb) { - err = -ENOMEM; + if (!skb) goto out; - } if (iucv->transport == AF_IUCV_TRANS_HIPER) skb_reserve(skb, sizeof(struct af_iucv_trans_hdr) + ETH_HLEN); if (memcpy_from_msg(skb_put(skb, len), msg, len)) { -- 2.1.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] af_iucv: fix AF_IUCV sendmsg() errno 2015-03-30 13:40 ` [PATCH net 1/1] " Ursula Braun @ 2015-03-31 20:07 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2015-03-31 20:07 UTC (permalink / raw) To: ubraun; +Cc: netdev, linux-s390, ursula.braun, Eugene.Crosser From: Ursula Braun <ubraun@linux.vnet.ibm.com> Date: Mon, 30 Mar 2015 15:40:42 +0200 > From: Eugene Crosser <Eugene.Crosser@ru.ibm.com> > > When sending over AF_IUCV socket, errno was incorrectly set to > ENOMEM even when other values where appropriate, notably EAGAIN. > With this patch, error indicator returned by sock_alloc_send_skb() > is passed to the caller, rather than being overwritten with ENOMEM. > > Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com> > Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-31 20:07 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-30 13:40 [PATCH net 0/1] af_iucv: fix AF_IUCV sendmsg() errno Ursula Braun 2015-03-30 13:40 ` [PATCH net 1/1] " Ursula Braun 2015-03-31 20:07 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).