From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: [PATCH v2 2/8] net/macb: add comment in macb_probe_queues Date: Tue, 31 Mar 2015 15:02:00 +0200 Message-ID: <1427806926-18887-3-git-send-email-nicolas.ferre@atmel.com> References: <1427806926-18887-1-git-send-email-nicolas.ferre@atmel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Boris BREZILLON , Cyrille Pitchen , Alexandre Belloni , , , Nicolas Ferre To: , , "David S. Miller" Return-path: Received: from eusmtp01.atmel.com ([212.144.249.243]:27311 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbbCaNCw (ORCPT ); Tue, 31 Mar 2015 09:02:52 -0400 In-Reply-To: <1427806926-18887-1-git-send-email-nicolas.ferre@atmel.com> Sender: netdev-owner@vger.kernel.org List-ID: As we access the MID register directly, we need to tell why we don't use the macb_is_gem() dedicated function. Signed-off-by: Nicolas Ferre --- Changes in v2: None drivers/net/ethernet/cadence/macb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index ac1f18142f7e..68d59b3900b1 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -2161,9 +2161,13 @@ static void macb_probe_queues(void __iomem *mem, *queue_mask = 0x1; *num_queues = 1; - /* is it macb or gem ? */ + /* is it macb or gem ? + * + * We need to read directly from the hardware here because + * we are early in the probe process and don't have the + * MACB_CAPS_MACB_IS_GEM flag positioned + */ mid = readl_relaxed(mem + MACB_MID); - if (MACB_BFEXT(IDNUM, mid) < 0x2) return; -- 2.1.3