From: Joe Perches <joe@perches.com>
To: monstr@monstr.eu
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0
Date: Tue, 31 Mar 2015 12:49:31 -0700 [thread overview]
Message-ID: <1427831371.18175.18.camel@perches.com> (raw)
In-Reply-To: <551A80AE.7020506@monstr.eu>
(shortened cc list)
On Tue, 2015-03-31 at 13:10 +0200, Michal Simek wrote:
> On 03/30/2015 03:25 AM, Joe Perches wrote:
> > Use bool constants as the return values instead of 1 and 0.
[]
> > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > index 2111b91..6008eee 100644
> > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > @@ -1062,7 +1062,7 @@ static bool get_bool(struct platform_device *ofdev, const char *s)
> > } else {
> > dev_warn(&ofdev->dev, "Parameter %s not found,"
> > "defaulting to false\n", s);
> > - return 0;
> > + return false;
> > }
> > }
>
> Kernel-doc should be also fixed in spite of this whole function is just
> broken and binding should be fixed to use of_property_read_bool for
> these properties.
Hi Michal.
David's applied this so if you or Sören want to fix up
the function and kernel-doc to your taste, please do.
cheers, Joe
next prev parent reply other threads:[~2015-03-31 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201503260524.AdqSbov9%fengguang.wu@intel.com>
2015-03-25 21:55 ` [PATCH] cxgb4: fix boolreturn.cocci warnings kbuild test robot
2015-03-25 22:14 ` Joe Perches
2015-03-29 19:16 ` David Miller
2015-03-30 1:25 ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Joe Perches
2015-03-30 1:29 ` [PATCH net-next] wireless: " Joe Perches
2015-03-30 1:46 ` Larry Finger
2015-03-30 1:49 ` Joe Perches
2015-04-07 17:11 ` [net-next] wireless: Use bool function returns of true/false insteadof 1/0 Kalle Valo
2015-03-30 20:28 ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Jeff Kirsher
2015-03-31 11:10 ` Michal Simek
2015-03-31 19:49 ` Joe Perches [this message]
2015-03-31 18:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427831371.18175.18.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).