From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: yanjiang.jin@windriver.com
Cc: bruce.w.allan@intel.com, john.ronciak@intel.com,
netdev@vger.kernel.org, jinyanjiang@gmail.com
Subject: Re: [PATCH] ethernet: e1000e: define lat_ns as u64 instead of s64
Date: Fri, 03 Apr 2015 02:42:39 -0700 [thread overview]
Message-ID: <1428054159.2662.82.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1428052673-16412-1-git-send-email-yanjiang.jin@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]
On Fri, 2015-04-03 at 17:17 +0800, yanjiang.jin@windriver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@windriver.com>
>
> do_div() expects the type of "n" to be uint64_t, define "lat_ns" as
> u64 to
> avoid the below warning, also update its correlative operations and
> data.
>
> In file included from ./arch/powerpc/include/asm/div64.h:1:0,
> from include/linux/kernel.h:124,
> from include/linux/list.h:8,
> from include/linux/timer.h:4,
> from drivers/net/ethernet/intel/e1000e/e1000.h:29,
> from drivers/net/ethernet/intel/e1000e/ich8lan.c:59:
> drivers/net/ethernet/intel/e1000e/ich8lan.c: In function
> 'e1000_platform_pm_pch_lpt':
> include/asm-generic/div64.h:43:28: warning: comparison of distinct
> pointer types lacks a cast [enabled by default]
> (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
> ^
> drivers/net/ethernet/intel/e1000e/ich8lan.c:1016:4: note: in expansion
> of macro 'do_div'
> do_div(lat_ns, speed);
>
> Signed-off-by: Yanjiang Jin <yanjiang.jin@windriver.com>
> ---
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Added intel-wired-lan mailing list (used for patches like this)
Removed LKML ... (wrong mailing list to be mailing for patches like
this)
Removed e1000-devel ... (no longer used for kernel patches)
Removed linux.nics ... (no longer used for kernel patches)
Also removed Intel developers with no interest in e1000e patches ...
Thanks Yanjiang, I will add your patch to my queue.
--
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-03 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:17 [PATCH] ethernet: e1000e: define lat_ns as u64 instead of s64 yanjiang.jin
2015-04-03 9:42 ` Jeff Kirsher [this message]
2015-04-07 2:35 ` yjin
2015-04-08 9:40 ` David Laight
2015-04-08 18:13 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428054159.2662.82.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=jinyanjiang@gmail.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yanjiang.jin@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).