From: Joe Perches <joe@perches.com>
To: Ian Morris <ipm@chirality.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv4: coding style: comparison for equality with NULL
Date: Fri, 03 Apr 2015 09:51:15 -0700 [thread overview]
Message-ID: <1428079875.13180.14.camel@perches.com> (raw)
In-Reply-To: <1428049047-14783-2-git-send-email-ipm@chirality.org.uk>
On Fri, 2015-04-03 at 09:17 +0100, Ian Morris wrote:
> The ipv4 code uses a mixture of coding styles. In some instances check
> for NULL pointer is done as x == NULL and sometimes as !x. !x is
> preferred according to checkpatch and this patch makes the code
> consistent by adopting the latter form.
Thanks Ian.
> 39 files changed, 210 insertions(+), 202 deletions(-)
A change like this would generally not add or remove lines.
It'd be nice if in the future, when a substitution like
this occurs and lines counts are changed that the commit
log states why.
For this case, maybe something like:
Hoisted a few assignments from if statements while there.
next prev parent reply other threads:[~2015-04-03 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 8:17 [PATCH net-next 0/2] ipv4: coding style - comparisons with NULL Ian Morris
2015-04-03 8:17 ` [PATCH net-next 1/2] ipv4: coding style: comparison for equality " Ian Morris
2015-04-03 16:51 ` Joe Perches [this message]
2015-04-03 8:17 ` [PATCH net-next 2/2] ipv4: coding style: comparison for inequality " Ian Morris
2015-04-03 16:11 ` [PATCH net-next 0/2] ipv4: coding style - comparisons " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428079875.13180.14.camel@perches.com \
--to=joe@perches.com \
--cc=ipm@chirality.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).