Re: [PATCH ethtool 2/5] ethtool: Add missing Advertised speeds

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 2512 bytes --]

On Sun, 2015-01-25 at 15:51 +0200, Amir Vadai wrote:
> From: Eyal Grossman <eyalgr@mellanox.com>
> 
> Added the following missing advertised speed modes:
> - ADVERTISED_10000baseT_Full
> - ADVERTISED_56000baseKR4_Full
> - ADVERTISED_56000baseCR4_Full
> - ADVERTISED_56000baseSR4_Full
> - ADVERTISED_56000baseLR4_Full
> - ADVERTISED_10000baseKX4_Full
> 
> In order to reduce code duplication we added a macro to
> ALL_ADVERTISED_FLAGS in line 88 ALL_ADVERTISED_MODES,
> in addition the changed we made added speed that were
> missing from ALL_ADVERTISED_MODES
> (e.g. ADVERTISED_10000baseKX4_Full).

Well spotted.

> Added ADVERTISED_10000baseR_FEC to mode_defs.
>
> Signed-off-by: Eyal Grossman <eyalgr@mellanox.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
> ---
[...]
> @@ -527,15 +516,20 @@ dump_link_caps(const char *prefix, const char *an_prefix, u32 mask,
>  		{ 1, ADVERTISED_1000baseT_Full,     "1000baseT/Full" },
>  		{ 0, ADVERTISED_1000baseKX_Full,    "1000baseKX/Full" },
>  		{ 0, ADVERTISED_2500baseX_Full,     "2500baseX/Full" },
> -		{ 0, ADVERTISED_10000baseT_Full,    "10000baseT/Full" },
> +		{ 1, ADVERTISED_10000baseT_Full,    "10000baseT/Full" },

Why should this be on the same line as 2500baseX/Full?

>  		{ 0, ADVERTISED_10000baseKX4_Full,  "10000baseKX4/Full" },
>  		{ 0, ADVERTISED_10000baseKR_Full,   "10000baseKR/Full" },
> +		{ 0, ADVERTISED_10000baseR_FEC,     "10000baseR/FEC" },

This is not a link mode, it's a separate capability that applies to all
10GBASE-R modes.  It's also meaningful for 40G and 100G modes despite
the way we've named the flags.  Please put it in a separate section
below the link modes.

Ben.

>  		{ 0, ADVERTISED_20000baseMLD2_Full, "20000baseMLD2/Full" },
>  		{ 0, ADVERTISED_20000baseKR2_Full,  "20000baseKR2/Full" },
>  		{ 0, ADVERTISED_40000baseKR4_Full,  "40000baseKR4/Full" },
>  		{ 0, ADVERTISED_40000baseCR4_Full,  "40000baseCR4/Full" },
>  		{ 0, ADVERTISED_40000baseSR4_Full,  "40000baseSR4/Full" },
>  		{ 0, ADVERTISED_40000baseLR4_Full,  "40000baseLR4/Full" },
> +		{ 0, ADVERTISED_56000baseKR4_Full,  "56000baseKR4/Full" },
> +		{ 0, ADVERTISED_56000baseCR4_Full,  "56000baseCR4/Full" },
> +		{ 0, ADVERTISED_56000baseSR4_Full,  "56000baseSR4/Full" },
> +		{ 0, ADVERTISED_56000baseLR4_Full,  "56000baseLR4/Full" },
>  	};
>  	int indent;
>  	int did1, new_line_pend, i;

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]