From: Ben Hutchings <ben@decadent.org.uk>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: return non-zero from do_sset() when any of ETHTOOL_{G,S}* fails
Date: Sun, 05 Apr 2015 02:55:48 +0100 [thread overview]
Message-ID: <1428198948.11260.133.camel@decadent.org.uk> (raw)
In-Reply-To: <1423236283-32446-1-git-send-email-ivecera@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Fri, 2015-02-06 at 16:24 +0100, Ivan Vecera wrote:
> Function do_sset returns unconditionally zero error code without regard
> to return value of ETHTOOL_{G,S}* ioctls.
[...]
This behaviour is stupid, but it's what ethtool has always done and what
some scripts will depend on now. If you can think of a simple way for
scripts to opt-in to sensible exit codes, please submit that.
Also, negative exit codes aren't sensible; please just use 0 and 1.
Ben.
--
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2015-04-05 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 15:24 [PATCH] ethtool: return non-zero from do_sset() when any of ETHTOOL_{G,S}* fails Ivan Vecera
2015-03-25 16:58 ` Ivan Vecera
2015-04-05 1:55 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428198948.11260.133.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).