From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
davem@davemloft.net, eric.dumazet@gmail.com
Subject: Re: [Intel-wired-lan] [PATCH 1/3 net-next] e1000: Allocate pm_qos_req as needed
Date: Thu, 09 Apr 2015 21:35:39 -0700 [thread overview]
Message-ID: <1428640539.2729.67.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1428624503.2729.55.camel@jtkirshe-mobl>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Thu, 2015-04-09 at 17:08 -0700, Jeff Kirsher wrote:
> On Fri, 2015-04-10 at 01:43 +0200, Thomas Graf wrote:
> > e1000 is the only driver requiring pm_qos_req, instead of causing
> > every device to waste up to 240 bytes. Allocate it for the specific
> > driver.
> >
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
> > ---
> > drivers/net/ethernet/intel/e1000e/netdev.c | 15 +++++++++++----
> > include/linux/netdevice.h | 2 +-
> > 2 files changed, 12 insertions(+), 5 deletions(-)
>
> Small nitpick, it is e1000e not e1000 that you are modifying.
So other than the patch title and description referencing e1000 instead
of e1000e, patch looks fine.
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-10 4:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 23:43 [PATCH 0/3 net-next] Bring sizeof(net_device) down to < 2K bytes Thomas Graf
2015-04-09 23:43 ` [PATCH 1/3 net-next] e1000: Allocate pm_qos_req as needed Thomas Graf
2015-04-10 0:08 ` Jeff Kirsher
2015-04-10 4:35 ` Jeff Kirsher [this message]
2015-04-10 8:01 ` [Intel-wired-lan] " Daniel Borkmann
2015-04-10 8:48 ` Thomas Graf
2015-04-10 8:58 ` Jeff Kirsher
2015-04-09 23:43 ` [PATCH 2/3 net-next] net_device: Reorder members to fill holes Thomas Graf
2015-04-09 23:43 ` [PATCH 3/3 net-next] net_device: Add minimal padding to allow for net_device pointer alignment Thomas Graf
2015-04-10 0:34 ` Eric Dumazet
2015-04-10 8:48 ` Thomas Graf
2015-04-10 9:03 ` Eric Dumazet
2015-04-10 0:01 ` [PATCH 0/3 net-next] Bring sizeof(net_device) down to < 2K bytes Alexei Starovoitov
2015-04-10 8:41 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428640539.2729.67.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).