From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: [Patch net-next v2 2/5] fou: exit early when parsing config fails Date: Fri, 10 Apr 2015 12:00:27 -0700 Message-ID: <1428692430-14465-3-git-send-email-xiyou.wangcong@gmail.com> References: <1428692430-14465-1-git-send-email-xiyou.wangcong@gmail.com> Cc: Tom Herbert , Cong Wang To: netdev@vger.kernel.org Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:35437 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754288AbbDJTAn (ORCPT ); Fri, 10 Apr 2015 15:00:43 -0400 Received: by pabtp1 with SMTP id tp1so29806301pab.2 for ; Fri, 10 Apr 2015 12:00:43 -0700 (PDT) In-Reply-To: <1428692430-14465-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Not a big deal, just for corretness. Cc: Tom Herbert Signed-off-by: Cong Wang --- net/ipv4/fou.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index c8db627..ad0ee82 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -605,8 +605,11 @@ static int fou_nl_cmd_add_port(struct sk_buff *skb, struct genl_info *info) static int fou_nl_cmd_rm_port(struct sk_buff *skb, struct genl_info *info) { struct fou_cfg cfg; + int err; - parse_nl_config(info, &cfg); + err = parse_nl_config(info, &cfg); + if (err) + return err; return fou_destroy(&init_net, &cfg); } -- 1.8.3.1