* [PATCH] rtlwifi: misspelled code and comments corrected.
@ 2015-04-12 14:50 Cheolhyun Park
2015-04-12 15:56 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Cheolhyun Park @ 2015-04-12 14:50 UTC (permalink / raw)
To: Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ,
chaoming_li-kXabqFNEczNtrwSWzY7KCg, kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
linville-2XuSBdqkA4R54TAoqtyWWQ, pch851130-Re5JQEeQqe8AvxtiuMwx3w,
Julia.Lawall-L2FTfq7BK8M
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Cheolhyun Park <pch851130-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally arge false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 10000) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
- "Abnornally false alarm case.\n");
+ "Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: misspelled code and comments corrected.
2015-04-12 14:50 [PATCH] rtlwifi: misspelled code and comments corrected Cheolhyun Park
@ 2015-04-12 15:56 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-04-12 15:56 UTC (permalink / raw)
To: Cheolhyun Park
Cc: Larry.Finger, chaoming_li, kvalo, linville, linux-wireless,
netdev, linux-kernel
On Sun, 12 Apr 2015, Cheolhyun Park wrote:
> Signed-off-by: Cheolhyun Park <pch851130@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index f5ee67c..1273997 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
> struct dig_t *digtable = &rtlpriv->dm_digtable;
> u32 isbt;
>
> - /* modify DIG lower bound, deal with abnorally large false alarm */
> + /* modify DIG lower bound, deal with abnormally arge false alarm */
You have converted large to arge.
julia
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> digtable->large_fa_hit++;
> if (digtable->forbidden_igi < digtable->cur_igvalue) {
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index a1be5a6..f209cda 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
> "dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
> de_digtable->recover_cnt, de_digtable->rx_gain_min);
>
> - /* deal with abnorally large false alarm */
> + /* deal with abnormally large false alarm */
> if (falsealm_cnt->cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> "dm_DIG(): Abnormally false alarm case\n");
> diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> index 0b2082d..342678d 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> @@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
>
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> - "Abnornally false alarm case.\n");
> + "Abnormally false alarm case.\n");
>
> if (dm_digtable->large_fa_hit != 3)
> dm_digtable->large_fa_hit++;
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] rtlwifi: misspelled code and comments corrected.
@ 2015-04-12 16:04 Cheolhyun Park
2015-04-12 16:26 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Cheolhyun Park @ 2015-04-12 16:04 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, kvalo, pch851130, linville,
Julia.Lawall
Cc: linux-wireless, netdev, linux-kernel
Signed-off-by: Cheolhyun Park <pch851130@gmail.com>
---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index f5ee67c..1273997 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
struct dig_t *digtable = &rtlpriv->dm_digtable;
u32 isbt;
- /* modify DIG lower bound, deal with abnorally large false alarm */
+ /* modify DIG lower bound, deal with abnormally large false alarm */
if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
digtable->large_fa_hit++;
if (digtable->forbidden_igi < digtable->cur_igvalue) {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
index a1be5a6..f209cda 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
@@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
"dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
de_digtable->recover_cnt, de_digtable->rx_gain_min);
- /* deal with abnorally large false alarm */
+ /* deal with abnormally large false alarm */
if (falsealm_cnt->cnt_all > 10000) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
"dm_DIG(): Abnormally false alarm case\n");
diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
index 0b2082d..342678d 100644
--- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
+++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
@@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
- "Abnornally false alarm case.\n");
+ "Abnormally false alarm case.\n");
if (dm_digtable->large_fa_hit != 3)
dm_digtable->large_fa_hit++;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: misspelled code and comments corrected.
2015-04-12 16:04 Cheolhyun Park
@ 2015-04-12 16:26 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2015-04-12 16:26 UTC (permalink / raw)
To: Cheolhyun Park, chaoming_li, kvalo, linville, Julia.Lawall
Cc: linux-wireless, netdev, linux-kernel
On 04/12/2015 11:04 AM, Cheolhyun Park wrote:
> Signed-off-by: Cheolhyun Park <pch851130@gmail.com>
When you send a corrected patch, it is common to indicate that this is a
corrected patch by putting the version number inside the [] in the subject, and
to indicate the changes inside the patch, but after the --- line. Neither of
these annotations will be included in the commit message, but they help the
maintainer keep track of the patch, and whether you have satisfied the
reviewer's comments. Thus this patch should have had the subject "[PATCH V2]
rtlwifi: ..." and you should have had the lines below after the ---:
> ---
V2 - Fixed the typo introduced in V1 as noted by Julia Lawall.
---
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8821ae/dm.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index f5ee67c..1273997 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -312,7 +312,7 @@ static void rtl92c_dm_ctrl_initgain_by_rssi(struct ieee80211_hw *hw)
> struct dig_t *digtable = &rtlpriv->dm_digtable;
> u32 isbt;
>
> - /* modify DIG lower bound, deal with abnorally large false alarm */
> + /* modify DIG lower bound, deal with abnormally large false alarm */
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> digtable->large_fa_hit++;
> if (digtable->forbidden_igi < digtable->cur_igvalue) {
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index a1be5a6..f209cda 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -420,7 +420,7 @@ static void rtl92d_dm_dig(struct ieee80211_hw *hw)
> "dm_DIG() Before: Recover_cnt=%d, rx_gain_min=%x\n",
> de_digtable->recover_cnt, de_digtable->rx_gain_min);
>
> - /* deal with abnorally large false alarm */
> + /* deal with abnormally large false alarm */
> if (falsealm_cnt->cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> "dm_DIG(): Abnormally false alarm case\n");
> diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> index 0b2082d..342678d 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/dm.c
> @@ -873,7 +873,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
>
> if (rtlpriv->falsealm_cnt.cnt_all > 10000) {
> RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
> - "Abnornally false alarm case.\n");
> + "Abnormally false alarm case.\n");
>
> if (dm_digtable->large_fa_hit != 3)
> dm_digtable->large_fa_hit++;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-12 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-12 14:50 [PATCH] rtlwifi: misspelled code and comments corrected Cheolhyun Park
2015-04-12 15:56 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2015-04-12 16:04 Cheolhyun Park
2015-04-12 16:26 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).