From: Andreas Oetken <ennoerlangen@googlemail.com>
To: Vince Bridgers <vbridger@opensource.altera.com>,
netdev@vger.kernel.org, nios2-dev@lists.rocketboards.org
Cc: Andreas Oetken <ennoerlangen@gmail.com>,
Andreas Oetken <andreas@oetken.name>
Subject: [PATCH 1/1] altera tse: Fix network-delays and -retransmissions after high throughput.
Date: Tue, 14 Apr 2015 22:25:26 +0200 [thread overview]
Message-ID: <1429043126-10829-1-git-send-email-ennoerlangen@gmail.com> (raw)
From: Andreas Oetken <andreas@oetken.name>
Fix bug which occurs when more than <limit> packets are available during napi-poll,
leading to "delays" and retransmissions on the network.
Check for (count < limit) before checking the get_rx_status in tse_rx-function. get_rx_status is reading from the response-fifo.
If there is currently a response in the fifo, reading the last byte of the response pops the value from the fifo.
If the limit is check as second condition and the limit is reached the fifo is popped but the packet is not processed.
Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>
---
drivers/net/ethernet/altera/altera_tse_main.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 6725dc0..b927b8b 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -376,8 +376,12 @@ static int tse_rx(struct altera_tse_private *priv, int limit)
u16 pktlength;
u16 pktstatus;
- while (((rxstatus = priv->dmaops->get_rx_status(priv)) != 0) &&
- (count < limit)) {
+ /* Check for limit first. get_rx_status is reading the from the
+ * response-fifo. If there is a currently a response in the fifo,
+ * reading the last byte of the response pops the value from the fifo.
+ */
+ while ((count < limit) &&
+ ((rxstatus = priv->dmaops->get_rx_status(priv)) != 0)) {
pktstatus = rxstatus >> 16;
pktlength = rxstatus & 0xffff;
--
2.1.4
next reply other threads:[~2015-04-14 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 20:25 Andreas Oetken [this message]
2015-04-16 16:02 ` [PATCH 1/1] altera tse: Fix network-delays and -retransmissions after high throughput David Miller
2015-04-16 21:48 ` Andreas Oetken
2015-04-17 19:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429043126-10829-1-git-send-email-ennoerlangen@gmail.com \
--to=ennoerlangen@googlemail.com \
--cc=andreas@oetken.name \
--cc=ennoerlangen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=vbridger@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).