netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vince Bridgers <vbridger@opensource.altera.com>
To: <peppe.cavallaro@st.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <vbridger@opensource.altera.com>, <vbridger@altera.com>
Subject: [PATCH net 4/5] stmmac: Enable unicast pause frame detect in GMAC Register 6
Date: Wed, 15 Apr 2015 11:17:41 -0500	[thread overview]
Message-ID: <1429114662-1528-5-git-send-email-vbridger@opensource.altera.com> (raw)
In-Reply-To: <1429114662-1528-1-git-send-email-vbridger@opensource.altera.com>

Unicast pause frame detect was not being enabled for the Synopsys stmmac. This
patch sets Unicast pause frame detect in MAC register 6 so that pause frame
detection by the stmmac conforms to IEEE 802.3, Annex 31B.3.3 Receive
Operation - Specifically, a MAC shall respond to pause frames containing
either the reserved multicast address or the unique physical address
associated with this station.

Signed-off-by: Vince Bridgers <vbridger@opensource.altera.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index 0adcf73..371a669 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -201,7 +201,10 @@ static void dwmac1000_flow_ctrl(struct mac_device_info *hw, unsigned int duplex,
 				unsigned int fc, unsigned int pause_time)
 {
 	void __iomem *ioaddr = hw->pcsr;
-	unsigned int flow = 0;
+	/* Set flow such that DZPQ in Mac Register 6 is 0,
+	 * and unicast pause detect is enabled.
+	 */
+	unsigned int flow = GMAC_FLOW_CTRL_UP;
 
 	pr_debug("GMAC Flow-Control:\n");
 	if (fc & FLOW_RX) {
-- 
1.9.1

  parent reply	other threads:[~2015-04-15 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 16:17 [PATCH net 0/5] stmmac: Correct flow control configuration Vince Bridgers
2015-04-15 16:17 ` [PATCH net 1/5] stmmac: Add properties for transmit and receive fifo sizes Vince Bridgers
2015-04-15 16:17 ` [PATCH net 2/5] stmmac: Add defines and documentation for enabling flow control Vince Bridgers
2015-04-15 16:17 ` [PATCH net 3/5] stmmac: Read tx-fifo-depth and rx-fifo-depth from the devicetree Vince Bridgers
2015-04-15 16:17 ` Vince Bridgers [this message]
2015-04-15 16:17 ` [PATCH net 5/5] stmmac: Configure Flow Control to work correctly based on rxfifo size Vince Bridgers
2015-04-16  7:22 ` [PATCH net 0/5] stmmac: Correct flow control configuration Giuseppe CAVALLARO
2015-04-16 18:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429114662-1528-5-git-send-email-vbridger@opensource.altera.com \
    --to=vbridger@opensource.altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=vbridger@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).