From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: joe@perches.com, apw@canonical.com
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] checkpatch: new ethernet address manipulation checks
Date: Mon, 20 Apr 2015 00:16:54 +0200 [thread overview]
Message-ID: <1429481816-6664-1-git-send-email-mateusz.kulikowski@gmail.com> (raw)
Changes in v2 (applied review comments):
- Fixed indentation in both patches
- Detect memset(foo, 0x00, ETH_ALEN)
- Detect memset(foo, 255, ETH_ALEN)
- Rephrased 2/2 commit message
Patch Notes from v1:
Add 3 new warnings to checkpatch:
1) PREFER_ETHER_ADDR_EQUAL
Replace memcmp(foo, bar, ETH_ALEN) with ether_addr_equal*()
2) PREFER_ETH_ZERO_ADDR
Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr()
3) PREFER_ETH_BROADCAST_ADDR
Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr()
Mateusz Kulikowski (2):
checkpatch: suggest using ether_addr_equal*()
checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()
scripts/checkpatch.pl | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
--
1.8.4.1
next reply other threads:[~2015-04-19 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 22:16 Mateusz Kulikowski [this message]
2015-04-19 22:16 ` [PATCH v2 1/2] checkpatch: suggest using ether_addr_equal*() Mateusz Kulikowski
2015-04-19 22:16 ` [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() Mateusz Kulikowski
2015-04-20 1:13 ` Joe Perches
2015-04-21 20:57 ` Mateusz Kulikowski
2015-04-21 21:22 ` Joe Perches
2015-04-21 21:44 ` Mateusz Kulikowski
2015-04-21 22:27 ` Joe Perches
2015-04-23 19:53 ` Mateusz Kulikowski
2015-04-23 23:54 ` Joe Perches
2015-04-23 23:55 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429481816-6664-1-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).