From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] pppoe: Lacks DST MAC address check
Date: Mon, 20 Apr 2015 19:02:06 +0000 [thread overview]
Message-ID: <1429556526.24234.12.camel@transmode.se> (raw)
In-Reply-To: <20150420.141158.32627615256852547.davem@davemloft.net>
On Mon, 2015-04-20 at 14:11 -0400, David Miller wrote:
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Sat, 18 Apr 2015 11:53:14 +0200
>
> > A pppoe session is identified by its session ID and MAC address.
> > Currently pppoe does not check if the received pkg has the correct
> > MAC address. This is a problem when the eth I/F is in promisc mode
> > as then any DST MAC address is accepted.
>
> Please read Documentation/SubmittingPatches in the source tree, you
> need to provide a proper signoff.
Arg! I know this but this time it slipped my mind :(
So sorry, I will send a v3 soon.
Jocke
prev parent reply other threads:[~2015-04-20 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 9:53 [PATCH v2] pppoe: Lacks DST MAC address check Joakim Tjernlund
2015-04-20 18:11 ` David Miller
2015-04-20 19:02 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429556526.24234.12.camel@transmode.se \
--to=joakim.tjernlund@transmode.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).