* [PATCH v2] pppoe: Lacks DST MAC address check
@ 2015-04-18 9:53 Joakim Tjernlund
2015-04-20 18:11 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Joakim Tjernlund @ 2015-04-18 9:53 UTC (permalink / raw)
To: netdev; +Cc: Joakim Tjernlund
A pppoe session is identified by its session ID and MAC address.
Currently pppoe does not check if the received pkg has the correct
MAC address. This is a problem when the eth I/F is in promisc mode
as then any DST MAC address is accepted.
---
v2 - The MAC address check should encompass all pppoe pkgs,
not only the relay type.
drivers/net/ppp/pppoe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index ff059e1..aa1dd92 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -380,6 +380,9 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
* can't change.
*/
+ if (skb->pkt_type == PACKET_OTHERHOST)
+ goto abort_kfree;
+
if (sk->sk_state & PPPOX_BOUND) {
ppp_input(&po->chan, skb);
} else if (sk->sk_state & PPPOX_RELAY) {
--
2.0.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pppoe: Lacks DST MAC address check
2015-04-18 9:53 [PATCH v2] pppoe: Lacks DST MAC address check Joakim Tjernlund
@ 2015-04-20 18:11 ` David Miller
2015-04-20 19:02 ` Joakim Tjernlund
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2015-04-20 18:11 UTC (permalink / raw)
To: Joakim.Tjernlund; +Cc: netdev
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Sat, 18 Apr 2015 11:53:14 +0200
> A pppoe session is identified by its session ID and MAC address.
> Currently pppoe does not check if the received pkg has the correct
> MAC address. This is a problem when the eth I/F is in promisc mode
> as then any DST MAC address is accepted.
Please read Documentation/SubmittingPatches in the source tree, you
need to provide a proper signoff.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] pppoe: Lacks DST MAC address check
2015-04-20 18:11 ` David Miller
@ 2015-04-20 19:02 ` Joakim Tjernlund
0 siblings, 0 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2015-04-20 19:02 UTC (permalink / raw)
To: davem@davemloft.net; +Cc: netdev@vger.kernel.org
On Mon, 2015-04-20 at 14:11 -0400, David Miller wrote:
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Sat, 18 Apr 2015 11:53:14 +0200
>
> > A pppoe session is identified by its session ID and MAC address.
> > Currently pppoe does not check if the received pkg has the correct
> > MAC address. This is a problem when the eth I/F is in promisc mode
> > as then any DST MAC address is accepted.
>
> Please read Documentation/SubmittingPatches in the source tree, you
> need to provide a proper signoff.
Arg! I know this but this time it slipped my mind :(
So sorry, I will send a v3 soon.
Jocke
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-20 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-18 9:53 [PATCH v2] pppoe: Lacks DST MAC address check Joakim Tjernlund
2015-04-20 18:11 ` David Miller
2015-04-20 19:02 ` Joakim Tjernlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).