netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org,
	Alexander Duyck <alexander.h.duyck@redhat.com>
Subject: Re: [Patch net] igb: fix a typo in igb_reset_q_vector()
Date: Tue, 21 Apr 2015 17:29:37 -0700	[thread overview]
Message-ID: <1429662577.2638.201.camel@jtkirshe-mobl> (raw)
In-Reply-To: <5536EAA3.10701@lab.ntt.co.jp>

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

On Wed, 2015-04-22 at 09:26 +0900, Toshiaki Makita wrote:
> On 2015/04/22 8:20, Cong Wang wrote:
> > Fixes: 5536d2102a2d ("igb: Combine q_vector and ring allocation into a single function")
> > Cc: Alexander Duyck <alexander.h.duyck@redhat.com>
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> > ---
> >  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> > index 8457d03..85bbeb2 100644
> > --- a/drivers/net/ethernet/intel/igb/igb_main.c
> > +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> > @@ -1036,7 +1036,7 @@ static void igb_reset_q_vector(struct igb_adapter *adapter, int v_idx)
> >  		adapter->tx_ring[q_vector->tx.ring->queue_index] = NULL;
> >  
> >  	if (q_vector->rx.ring)
> > -		adapter->tx_ring[q_vector->rx.ring->queue_index] = NULL;
> > +		adapter->rx_ring[q_vector->rx.ring->queue_index] = NULL;
> >  
> >  	netif_napi_del(&q_vector->napi);
> >  
> 
> Hi Cong Wang,
> 
> I have already sent a patch to intel's tree.
> http://git.kernel.org/cgit/linux/kernel/git/jkirsher/net-queue.git/commit/?h=dev-queue&id=02ac4b65689f8df824117395fd8d160c04161a7b
> 
> Toshiaki Makita
> 

Oops, yeah.  I already have this in my queue.  I wondered why the patch
seemed familiar, Cong dropping your patch since I already have
Tochiaki's patch in my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-04-22  0:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 23:20 [Patch net] igb: fix a typo in igb_reset_q_vector() Cong Wang
2015-04-22  0:18 ` Jeff Kirsher
2015-04-22  0:26 ` Toshiaki Makita
2015-04-22  0:29   ` Jeff Kirsher [this message]
2015-04-22  4:35     ` Cong Wang
2015-04-22  7:16       ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429662577.2638.201.camel@jtkirshe-mobl \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).