From: Martin Willi <martin@strongswan.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Horia Geantă" <horia.geanta@freescale.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Paul Wouters" <pwouters@redhat.com>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>
Subject: Re: CCM/GCM implementation defect
Date: Thu, 23 Apr 2015 11:58:52 +0200 [thread overview]
Message-ID: <1429783132.3083.15.camel@martin> (raw)
In-Reply-To: <20150423090545.GA20369@gondor.apana.org.au>
Hi Herbert,
> > Does this mean that even the test vectors (crypto/testmgr.h) are broken?
>
> Indeed. The test vectors appear to be generated either through
> our implementation or by one that is identical to us.
I'm not sure about that. RFC4106 refers to [1] for test vectors, which
is still available at web.archive.org [2].
When looking for example at Test Case 3, this is the same as in a newer
revision of the document [3]. That looks exactly the same as
aes_gcm_enc_tv_template[2] from testmgr.h.
We by the way use test vectors in userland from the same document to
verify our own GCM backend, our OpenSSL backend and an AESNI/PCLMULQD
backend. And I've never heard of any incompatibilities.
Regards
Martin
[1]http://csrc.nist.gov/CryptoToolkit/modes/proposedmodes/gcm/gcm-spec.pdf
[2]http://web.archive.org/web/20070712195408/http://csrc.nist.gov/CryptoToolkit/modes/proposedmodes/gcm/gcm-spec.pdf
[3]http://csrc.nist.gov/groups/ST/toolkit/BCM/documents/proposedmodes/gcm/gcm-revised-spec.pdf
next prev parent reply other threads:[~2015-04-23 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 3:26 CCM/GCM implementation defect Herbert Xu
2015-04-23 3:36 ` David Miller
2015-04-23 9:03 ` Horia Geantă
2015-04-23 9:05 ` Herbert Xu
2015-04-23 9:58 ` Martin Willi [this message]
2015-04-23 10:01 ` Herbert Xu
2015-04-23 11:45 ` Steffen Klassert
2015-04-23 13:24 ` Martin Willi
2015-04-23 23:12 ` Herbert Xu
2015-04-24 5:30 ` Herbert Xu
2015-04-24 5:35 ` Herbert Xu
2015-04-23 15:21 ` Paul Wouters
2015-04-23 23:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429783132.3083.15.camel@martin \
--to=martin@strongswan.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pwouters@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).