From: Martin Willi <martin@strongswan.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Paul Wouters <pwouters@redhat.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: CCM/GCM implementation defect
Date: Thu, 23 Apr 2015 15:24:59 +0200 [thread overview]
Message-ID: <1429795499.31437.9.camel@martin> (raw)
In-Reply-To: <20150423114533.GI8928@secunet.com>
Hi Steffen,
> > It looks like our IPsec implementations of CCM and GCM are buggy
> > in that they don't include the IV in the authentication calculation.
>
> Seems like crypto_rfc4106_crypt() passes the associated data it
> got from ESP directly to gcm, without chaining with the IV.
Do you have any pointer for me where this is defined? Why is it needed,
given that GCM implicitly authenticates the IV by using it in Y0?
Also, I've just verified that a tunnel between the Windows Filtering
Platform and Linux 3.13 using AES128GCM16 works just fine. So if we do
something wrong, the problem does not only affect Linux.
Regards
Martin
next prev parent reply other threads:[~2015-04-23 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 3:26 CCM/GCM implementation defect Herbert Xu
2015-04-23 3:36 ` David Miller
2015-04-23 9:03 ` Horia Geantă
2015-04-23 9:05 ` Herbert Xu
2015-04-23 9:58 ` Martin Willi
2015-04-23 10:01 ` Herbert Xu
2015-04-23 11:45 ` Steffen Klassert
2015-04-23 13:24 ` Martin Willi [this message]
2015-04-23 23:12 ` Herbert Xu
2015-04-24 5:30 ` Herbert Xu
2015-04-24 5:35 ` Herbert Xu
2015-04-23 15:21 ` Paul Wouters
2015-04-23 23:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429795499.31437.9.camel@martin \
--to=martin@strongswan.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pwouters@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).