From: Fan Du <fan.du@intel.com>
To: jeffrey.t.kirsher@intel.com
Cc: alexander.h.duyck@redhat.com, emil.s.tantilov@intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Fan Du <fan.du@intel.com>
Subject: [PATCH v2 1/3] ixgbe: Specify rx hash type wrt rx desc RSS type
Date: Wed, 29 Apr 2015 10:57:39 +0800 [thread overview]
Message-ID: <1430276261-29821-2-git-send-email-fan.du@intel.com> (raw)
In-Reply-To: <1430276261-29821-1-git-send-email-fan.du@intel.com>
RSS could be leveraged by taking account L4 src/dst ports
as ingredients, thus ingress skb rx hash type should honor
such the real configuration.
Signed-off-by: Fan Du <fan.du@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 +++++++++++++++++++++----
1 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index d3f4b0c..5df896b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -1357,14 +1357,31 @@ static int __ixgbe_notify_dca(struct device *dev, void *data)
}
#endif /* CONFIG_IXGBE_DCA */
+
+#define IXGBE_RSS_L4_TYPES_MASK \
+ ((1ul << IXGBE_RXDADV_RSSTYPE_IPV4_TCP) | \
+ (1ul << IXGBE_RXDADV_RSSTYPE_IPV4_UDP) | \
+ (1ul << IXGBE_RXDADV_RSSTYPE_IPV6_TCP) | \
+ (1ul << IXGBE_RXDADV_RSSTYPE_IPV6_UDP))
+
static inline void ixgbe_rx_hash(struct ixgbe_ring *ring,
union ixgbe_adv_rx_desc *rx_desc,
struct sk_buff *skb)
{
- if (ring->netdev->features & NETIF_F_RXHASH)
- skb_set_hash(skb,
- le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),
- PKT_HASH_TYPE_L3);
+ u16 rss_type;
+
+ if (!(ring->netdev->features & NETIF_F_RXHASH))
+ return;
+
+ rss_type = le16_to_cpu(rx_desc->wb.lower.lo_dword.hs_rss.pkt_info) &
+ IXGBE_RXDADV_RSSTYPE_MASK;
+
+ if (!rss_type)
+ return;
+
+ skb_set_hash(skb, le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),
+ (IXGBE_RSS_L4_TYPES_MASK & (1ul << rss_type)) ?
+ PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);
}
#ifdef IXGBE_FCOE
--
1.7.1
next prev parent reply other threads:[~2015-04-29 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 2:57 [PATCH v2 0/3] RSS fix for ixgbe/ixgbevf Fan Du
2015-04-29 2:57 ` Fan Du [this message]
2015-05-06 22:45 ` [Intel-wired-lan] [PATCH v2 1/3] ixgbe: Specify rx hash type wrt rx desc RSS type Schmitt, Phillip J
2015-04-29 2:57 ` [PATCH v2 2/3] ixgbevf: Set rx hash type for ingress packets Fan Du
2015-05-06 22:45 ` [Intel-wired-lan] " Schmitt, Phillip J
2015-04-29 2:57 ` [PATCH v2 3/3] ixgbe: Don't report flow director filter's status Fan Du
2015-05-06 22:46 ` [Intel-wired-lan] " Schmitt, Phillip J
2015-04-30 12:59 ` [PATCH v2 0/3] RSS fix for ixgbe/ixgbevf Jeff Kirsher
2015-05-06 19:47 ` [Intel-wired-lan] " Schmitt, Phillip J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430276261-29821-2-git-send-email-fan.du@intel.com \
--to=fan.du@intel.com \
--cc=alexander.h.duyck@redhat.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).