From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <catalin.marinas@arm.com>,
<will.deacon@arm.com>, <thomas.lendacky@amd.com>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: al.stone@linaro.org, arnd@arndb.de, linaro-acpi@lists.linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, leo.duran@amd.com,
hanjun.guo@linaro.org,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
msalter@redhat.com, grant.likely@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org
Subject: [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent()
Date: Tue, 5 May 2015 10:12:07 -0500 [thread overview]
Message-ID: <1430838729-21572-4-git-send-email-Suravee.Suthikulpanit@amd.com> (raw)
In-Reply-To: <1430838729-21572-1-git-send-email-Suravee.Suthikulpanit@amd.com>
Currently, device drivers, which support both OF and ACPI,
need to call two separate APIs, of_dma_is_coherent() and
acpi_dma_is_coherent()) to determine device coherency attribute.
This patch simplifies this process by introducing a new device
property API, device_dma_is_coherent(), which calls the appropriate
interface based on the booting architecture.
Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
---
drivers/base/property.c | 12 ++++++++++++
include/linux/property.h | 2 ++
2 files changed, 14 insertions(+)
diff --git a/drivers/base/property.c b/drivers/base/property.c
index 1d0b116..8123c6e 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -14,6 +14,7 @@
#include <linux/export.h>
#include <linux/kernel.h>
#include <linux/of.h>
+#include <linux/of_address.h>
#include <linux/property.h>
/**
@@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct device *dev)
return count;
}
EXPORT_SYMBOL_GPL(device_get_child_node_count);
+
+bool device_dma_is_coherent(struct device *dev)
+{
+ if (IS_ENABLED(CONFIG_OF) && dev->of_node)
+ return of_dma_is_coherent(dev->of_node);
+ else if (has_acpi_companion(dev))
+ return acpi_dma_is_coherent(acpi_node(dev->fwnode));
+
+ return false;
+}
+EXPORT_SYMBOL_GPL(device_dma_is_coherent);
diff --git a/include/linux/property.h b/include/linux/property.h
index de8bdf4..76ebde9 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -164,4 +164,6 @@ struct property_set {
void device_add_property_set(struct device *dev, struct property_set *pset);
+bool device_dma_is_coherent(struct device *dev);
+
#endif /* _LINUX_PROPERTY_H_ */
--
2.1.0
next prev parent reply other threads:[~2015-05-05 15:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 15:12 [V2 PATCH 0/5] Introduce ACPI _CCA support and device_dma_is_coherent API Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency Suravee Suthikulpanit
2015-05-05 20:36 ` Rafael J. Wysocki
2015-05-06 4:15 ` Suravee Suthikulpanit
2015-05-06 22:21 ` Rafael J. Wysocki
2015-05-06 22:16 ` Suravee Suthikulanit
2015-05-07 9:07 ` [Linaro-acpi] " Arnd Bergmann
2015-05-07 20:18 ` Rafael J. Wysocki
2015-05-06 3:13 ` Hanjun Guo
2015-05-06 4:17 ` Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object Suravee Suthikulpanit
2015-05-05 15:44 ` Arnd Bergmann
2015-05-05 16:09 ` Suravee Suthikulanit
2015-05-05 16:12 ` [Linaro-acpi] " Arnd Bergmann
2015-05-05 16:13 ` Suravee Suthikulanit
2015-05-05 16:24 ` Tom Lendacky
2015-05-05 18:02 ` Arnd Bergmann
2015-05-06 10:08 ` Robin Murphy
2015-05-06 14:34 ` Suravee Suthikulanit
2015-05-05 15:12 ` Suravee Suthikulpanit [this message]
2015-05-06 23:52 ` [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent() Suravee Suthikulanit
2015-05-06 23:58 ` Rafael J. Wysocki
2015-05-05 15:12 ` [V2 PATCH 4/5] crypto: ccp - Unify coherency checking logic with device_dma_is_coherent() Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 5/5] amd-xgbe: " Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430838729-21572-4-git-send-email-Suravee.Suthikulpanit@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=grant.likely@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thomas.lendacky@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).