From: Joe Perches <joe@perches.com>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] adm8211: fix the possible pci cache line sizes inside switch-case
Date: Tue, 05 May 2015 15:01:53 -0700 [thread overview]
Message-ID: <1430863313.9365.49.camel@perches.com> (raw)
In-Reply-To: <20150505214851.GA3013@bytefire-computer>
On Tue, 2015-05-05 at 22:48 +0100, Okash Khawaja wrote:
> The PCI cache line size value, stored in cline variable, was being
> compared against decimal values written as hex literals. This patch
> changes those literals to correct hex values.
This is fine.
The grammar might be better as something like:
The PCI cache line size value was being compared against
decimal values prefixed with 0x.
Fix the literals to use the correct hex values.
> Please note that this patch is on top of
> another code cleanup patch '[PATCH] adm8211: fix checkpatch errors for
> indentation and new line around switch-case'.
But this information doesn't belong here as
it would also be in a git log when someone
uses git am to apply it to a tree.
It'd be better to send a patch series using
"git format-email --cover-letter -2 -o <dir>"
and use git send-email for the series.
next prev parent reply other threads:[~2015-05-05 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 21:48 [PATCH] adm8211: fix the possible pci cache line sizes inside switch-case Okash Khawaja
2015-05-05 22:01 ` Joe Perches [this message]
2015-05-05 22:50 ` Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430863313.9365.49.camel@perches.com \
--to=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).