From: Oliver Neukum <oneukum@suse.de>
To: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: allow MTU that is a multiple of USB packet size
Date: Thu, 07 May 2015 12:11:17 +0200 [thread overview]
Message-ID: <1430993477.30151.6.camel@suse.de> (raw)
In-Reply-To: <1430992159-27783-1-git-send-email-ruslan.bilovol@gmail.com>
On Thu, 2015-05-07 at 12:49 +0300, Ruslan Bilovol wrote:
> Current usbnet driver rejects setting MTU that is a multiple
> of USB endpoint's wMaxPacketSize size. However, it may only
> lead to possible performance degradation but is not so
> critical that its using should be prohibited. So allow it
> but also warn user about possible issue.
We have reports about devices reacting badly to ZLPs.
Unless you have a compelling reasons for this change
I have to reject it.
Regards
Oliver
NACK
next prev parent reply other threads:[~2015-05-07 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 9:49 [PATCH] net: usb: allow MTU that is a multiple of USB packet size Ruslan Bilovol
2015-05-07 10:11 ` Oliver Neukum [this message]
[not found] ` <1430993477.30151.6.camel-l3A5Bk7waGM@public.gmane.org>
2015-05-07 10:51 ` Ruslan Bilovol
2015-05-07 11:07 ` Oliver Neukum
2015-05-07 16:19 ` David Laight
2015-05-07 13:24 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430993477.30151.6.camel@suse.de \
--to=oneukum@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).