From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A94B325707; Tue, 23 Jun 2026 16:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233675; cv=none; b=CYHx91c/cUce6qS/K6Fc1rxjLt6t0ZVZOk+lQGTVsusFWsypWV26RjedcRcWXSzGcJ8Rxe/dLqib+JXr7uvOGM/0+Qizf2QKcZdVuSz+SavyNVfR8US2ipvK0n2jxIm3Rk5dg4FteU0fY95225cMy7SWRUBlvPQ4p9uFlB4Md5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233675; c=relaxed/simple; bh=eEWmWbc7CoAG5y/b2pd6/uqYzbmI44X9J9i3q/Xs+Jw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HRO3AWIrdzpmQGY9d7TGAlg27p9GlQWSLhJCDL/DEXCeB7bDuoeQ7k9LsnzG4qeqkoZ7fJ+yqGV1bCRtHm8WWubcOuako48CIwTbLbr/KMkcGcphFGqkkPGsRepTlbali4d6HaKtJZuNAxrLy7BEJsWQyfueIyG2Lty56mIDjuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aVAhQo1D; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aVAhQo1D" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id D2D66C6B397; Tue, 23 Jun 2026 16:54:39 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3FB72601C2; Tue, 23 Jun 2026 16:54:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A4181106C8382; Tue, 23 Jun 2026 18:54:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782233671; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=V0GuOlYRzJM4pDQWpmA6usQcahnlbuw1Vm/ChjlY/AI=; b=aVAhQo1Dl8B067G6c6X1YlKSceYxNORBwII2/tFPIRcS3+FcEBJ9ix/7L1fpUQ3e74MNjA iWV4EKuSIDPyTGlSiuvg76b0/1onRG+MJFEDF0ZrHf2ePk28OJArBYcUMIZhmUuQRd/DD3 wsq50D8mKAob+JsOdHGnJFiBQRfJ4A7yLmvl/pVbISU2has5sBS8ZvNra9M0vKwoKVF3Tq rWFrp+kRbHaYwKygVplxYTDreeAm3B7FAf+0Pi8SAjC65WqFVpXpMpeOU2SRqLAx+Kl+mu 4yTMA9wtb1o5+lcslnUa9EvsU6oHd1l6P3M9u8trBHvenKcQkuYqGurScb7yRg== Message-ID: <143145af-5846-4a7b-9953-33c51b1dbef3@bootlin.com> Date: Tue, 23 Jun 2026 18:54:28 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 2/2] net: stmmac: dwmac-spacemit: Fix wrong irq definition To: Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Yixun Lan , "Russell King (Oracle)" Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li References: <20260623074637.503864-1-inochiama@gmail.com> <20260623074637.503864-3-inochiama@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260623074637.503864-3-inochiama@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 6/23/26 09:46, Inochi Amaoto wrote: > The current irq definition of the wake irq and the lpi irq > is wrong, replace them with the right number and name. > > Fixes: 30f0ba420ed3 ("net: stmmac: Add glue layer for Spacemit K3 SoC") > Signed-off-by: Inochi Amaoto Reviewed-by: Maxime Chevallier Maxime > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > index 3bfb6d49be6c..322bdf167a4a 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > @@ -22,8 +22,8 @@ > #define CTRL_PHY_INTF_RMII FIELD_PREP(CTRL_PHY_INTF_MODE, 0) > #define CTRL_PHY_INTF_RGMII FIELD_PREP(CTRL_PHY_INTF_MODE, 1) > #define CTRL_PHY_INTF_MII FIELD_PREP(CTRL_PHY_INTF_MODE, 3) > -#define CTRL_WAKE_IRQ_EN BIT(9) > -#define CTRL_PHY_IRQ_EN BIT(12) > +#define CTRL_LPI_IRQ_EN BIT(9) > +#define CTRL_WAKE_IRQ_EN BIT(12) > > /* dline register bits */ > #define RGMII_RX_DLINE_EN BIT(0)