From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>,
linux-driver@qlogic.com, netdev <netdev@vger.kernel.org>
Subject: Re: qla3xxx: Odd likely incorrect use of test_bit in qla3xxx.c
Date: Wed, 13 May 2015 09:08:14 -0700 [thread overview]
Message-ID: <1431533294.2912.8.camel@perches.com> (raw)
In-Reply-To: <20150513131908.GB8431@mwanda>
On Wed, 2015-05-13 at 16:19 +0300, Dan Carpenter wrote:
> I wrote a Smatch check to find similar bugs.
Nice.
It didn't look like something coccinelle could do and
I didn't know smatch syntax well enough (OK, I don't
know smatch syntax at all), to write something to find
these defects but I thought, if anyone, you could.
Thanks Dan for doing it.
> ath9k had memory corruption because they do:
> set_bit(BIT(6), &some_unsigned_long);
> Anyway, I'll send patches for the bugs I found and push the Smatch
> check.
next prev parent reply other threads:[~2015-05-13 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 18:42 qla3xxx: Odd likely incorrect use of test_bit in qla3xxx.c Joe Perches
2015-05-13 13:19 ` Dan Carpenter
2015-05-13 16:08 ` Joe Perches [this message]
2015-05-13 17:34 ` Joe Perches
2015-05-14 8:01 ` Dan Carpenter
2015-05-14 8:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431533294.2912.8.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).