From: Simon Horman <simon.horman@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>, Scott Feldman <sfeldma@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Simon Horman <simon.horman@netronome.com>
Subject: [PATCH net-next 0/4] rocker: transaction fixes
Date: Tue, 19 May 2015 15:24:13 +0900 [thread overview]
Message-ID: <1432016657-24231-1-git-send-email-simon.horman@netronome.com> (raw)
Hi,
this series addresses what appear to be errors in the handling of
prepare and then commit transactions in the rocker driver.
In all cases the problem is that data structures visible outside of
the transaction are modified during the prepare phase.
In the case of the first two patches this results in the kernel reporting a
BUG. I have noted test-cases in the change logs.
The remaining two patches do not fix bugs that manifest as far as
I can tell. Rather, they are correctness fixes.
Simon Horman (4):
rocker: do not delete fdb entries in rocker_port_fdb_flush() when
preparing transactions
rocker: do not modify fdb table in rocker_port_fdb() when preparing
transactions
rocker: do not make neighbour entry changes when preparing
transactions
rocker: make rocker_port_internal_vlan_id_{get,put}()
non-transactional
drivers/net/ethernet/rocker/rocker.c | 46 ++++++++++++++++++++----------------
1 file changed, 25 insertions(+), 21 deletions(-)
--
2.1.4
next reply other threads:[~2015-05-19 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 6:24 Simon Horman [this message]
2015-05-19 6:24 ` [PATCH net-next 1/4] rocker: do not delete fdb entries in rocker_port_fdb_flush() when preparing transactions Simon Horman
2015-05-19 15:57 ` Scott Feldman
2015-05-19 6:24 ` [PATCH net-next 2/4] rocker: do not modify fdb table in rocker_port_fdb() " Simon Horman
2015-05-19 16:01 ` Scott Feldman
2015-05-19 6:24 ` [PATCH net-next 3/4] rocker: do not make neighbour entry changes " Simon Horman
2015-05-19 8:32 ` Toshiaki Makita
2015-05-20 1:53 ` Simon Horman
2015-05-19 16:11 ` Scott Feldman
2015-05-19 22:33 ` Simon Horman
2015-05-19 6:24 ` [PATCH net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}() non-transactional Simon Horman
2015-05-19 16:04 ` Scott Feldman
2015-05-19 16:13 ` [PATCH net-next 0/4] rocker: transaction fixes Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432016657-24231-1-git-send-email-simon.horman@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).