netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Parameswaran <aparames@broadcom.com>
To: Ben Hutchings <bwh@kernel.org>
Cc: <netdev@vger.kernel.org>, <jdzheng@broadcom.com>,
	<aparames@broadcom.com>
Subject: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's
Date: Fri, 22 May 2015 15:43:27 -0700	[thread overview]
Message-ID: <1432334609-3971-1-git-send-email-aparames@broadcom.com> (raw)

Hi,
The patch fixes 2 issues with 'ethtool' getting/setting parametres in
the do_gset() do_sset() API's.

I have pushed a patch to the Kernel to fix an issue in the handling of
the 'ethtool' commands which got accepted.
This Kernel patch was based on Linux v4.1-rc4 and is available in:
https://github.com/Broadcom/cygnus-linux/tree/net-core-ethtool-fix-v1

The Kernel was always clearing the command from the 'ethtool' resulting
in all operations to deal with PHY0. This prevents querying/setting
PHY 1's settings.

The first patch is required due to the fact that Kernel will not be
clearing the command data structure. Without this the query will fail
as the command will get to the Kernel with arbitary phyad info.

The second patch is to fix the issue in which the 'ethtool' gets the
settings of the wrong phyad before applying the new settings.

These changes will still work with older Kernel's (as the Kernel
clears the command data structure).

Thanks

Arun Parameswaran (2):
  ethtool: Clear the command data structure before sending requests
  ethtool: Fix an issue with handling 'phyad' while updating settings

 ethtool.c |    9 +++++++++
 1 file changed, 9 insertions(+)

-- 
1.7.9.5

             reply	other threads:[~2015-05-22 22:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 22:43 Arun Parameswaran [this message]
2015-05-22 22:43 ` [PATCH 1/2] ethtool: Clear the command data structure before sending requests Arun Parameswaran
2015-05-22 22:43 ` [PATCH 2/2] ethtool: Fix an issue with handling 'phyad' while updating settings Arun Parameswaran
2015-05-31 19:59 ` [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's Ben Hutchings
2015-06-01 17:14   ` Arun Parameswaran
2015-06-01 18:07     ` Ben Hutchings
2015-06-01 19:12       ` Arun Parameswaran
2015-06-01 19:29         ` Ben Hutchings
2015-06-01 21:00           ` Arun Parameswaran
2015-06-01 21:39           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432334609-3971-1-git-send-email-aparames@broadcom.com \
    --to=aparames@broadcom.com \
    --cc=bwh@kernel.org \
    --cc=jdzheng@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).