From: Shailendra Verma <shailendra.capricorn@gmail.com>
To: Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Shailendra Verma <shailendra.capricorn@gmail.com>
Subject: [PATCH] atm:he - Do not initialise statics to 0.
Date: Tue, 26 May 2015 01:23:53 +0530 [thread overview]
Message-ID: <1432583633-5129-1-git-send-email-shailendra.capricorn@gmail.com> (raw)
Static variables are initialised to 0 by GCC.
Fixes the following checkpatch error:
ERROR: do not initialise statics to 0 or NULL
FILE: drivers/atm/he.c:120:
static bool sdh = 0;
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
drivers/atm/he.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 93dca2e..2cd6f17 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -117,7 +117,7 @@ static short nvpibits = -1;
static short nvcibits = -1;
static short rx_skb_reserve = 16;
static bool irq_coalesce = 1;
-static bool sdh = 0;
+static bool sdh;
/* Read from EEPROM = 0000 0011b */
static unsigned int readtab[] = {
--
1.7.9.5
next reply other threads:[~2015-05-25 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 19:53 Shailendra Verma [this message]
2015-05-25 20:36 ` [PATCH] atm:he - Do not initialise statics to 0 David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-06-04 14:41 Shailendra Verma
2015-06-04 22:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432583633-5129-1-git-send-email-shailendra.capricorn@gmail.com \
--to=shailendra.capricorn@gmail.com \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).